Skip to content

TE-2.3: wait for IPv6 ARP before traffic; enable interface on Nokia - #6308

Open
snaragund wants to merge 1 commit into
openconfig:mainfrom
nokia:SND-TE2dot3
Open

snaragund wants to merge 1 commit into
openconfig:mainfrom
nokia:SND-TE2dot3

Conversation

@snaragund

Copy link
Copy Markdown
Contributor
  • Push and start OTG protocols after DUT configuration, then wait for IPv6 neighbor resolution before sending traffic in TestIPv6Entry and createTrafficFlows.
  • Set interface_enabled deviation for Nokia.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

 - Push and start OTG protocols after DUT configuration, then wait for IPv6 neighbor resolution before sending traffic in TestIPv6Entry and createTrafficFlows.
 - Set interface_enabled deviation for Nokia.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
@snaragund
snaragund requested a review from a team as a code owner November 20, 2026 11:29
@OpenConfigBot

Copy link
Copy Markdown

Pull Request Functional Test Report for #6308 / e2afd19

Virtual Devices

Device Test Status Test Documentation Job Raw Log
Arista cEOS status
TE-2.3: pending authorization
TE-2.3: gRIBI IPv6 Entry with Prefix Length > 64
Cisco 8000E status
TE-2.3: pending authorization
TE-2.3: gRIBI IPv6 Entry with Prefix Length > 64
Cisco XRd status
TE-2.3: pending authorization
TE-2.3: gRIBI IPv6 Entry with Prefix Length > 64
Juniper ncPTX status
TE-2.3: pending authorization
TE-2.3: gRIBI IPv6 Entry with Prefix Length > 64
Nokia SR Linux status
TE-2.3: pending authorization
TE-2.3: gRIBI IPv6 Entry with Prefix Length > 64
Openconfig Lemming status
TE-2.3: pending authorization
TE-2.3: gRIBI IPv6 Entry with Prefix Length > 64

Hardware Devices

Device Test Status Test Documentation Raw Log
Arista status
TE-2.3: pending authorization
TE-2.3: gRIBI IPv6 Entry with Prefix Length > 64
Cisco status
TE-2.3: pending authorization
TE-2.3: gRIBI IPv6 Entry with Prefix Length > 64
Juniper status
TE-2.3: pending authorization
TE-2.3: gRIBI IPv6 Entry with Prefix Length > 64
Nokia status
TE-2.3: pending authorization
TE-2.3: gRIBI IPv6 Entry with Prefix Length > 64

Help

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the IPv6 entry test suite to improve reliability by ensuring that IPv6 neighbor discovery completes before traffic generation begins. It also refactors the ATE configuration process to provide more granular control over protocol startup and includes necessary platform-specific deviations for Nokia devices.

Highlights

  • IPv6 Neighbor Resolution: Added explicit calls to wait for IPv6 ARP resolution before initiating traffic flows to ensure network stability.
  • Configuration Refactoring: Moved OTG configuration and protocol startup logic out of the helper function to allow for better control over the execution flow.
  • Nokia Platform Support: Enabled the 'interface_enabled' deviation in the metadata to support Nokia platform requirements.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ipv6_entry_test.go file to explicitly call otgutils.WaitForARP after starting OTG protocols across various test cases and helper functions, aligning with the repository's style guide for maintaining test stability. Additionally, it refactors configureATE to remove the inline OTG configuration push and protocol start, moving those operations to the main test flow. A new deviation interface_enabled: true is also added to the metadata.textproto file. There are no review comments to address, and the changes conform to the style guidelines, so I have no additional feedback to provide.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants