Skip to content

RT-7.5: clarify default import policy bgp behavior - #6309

Open
karthikeya-remilla wants to merge 2 commits into
openconfig:mainfrom
b4firex:rt-7.5-cisco
Open

karthikeya-remilla wants to merge 2 commits into
openconfig:mainfrom
b4firex:rt-7.5-cisco

Conversation

@karthikeya-remilla

@karthikeya-remilla karthikeya-remilla commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor
  • Rename the BGP import-policy deviation to describe implicit route acceptance.
  • Update link bandwidth tests and metadata to apply an explicit allow-all import policy when required, and revise the test README.
  • Reserve the removed metadata field and add the replacement field.
  • Remove the deviation for Cisco, and add a different one for other vendors to maintain vendor-neutral existing behavior of the test

@OpenConfigBot

OpenConfigBot commented Nov 20, 2026 •

Copy link
Copy Markdown

Pull Request Functional Test Report for #6309 / d5d0326

Virtual Devices

Device Test Status Test Documentation Job Raw Log
Arista cEOS status
RT-7.5: pending authorization
RT-7.5: BGP Policy - Match and Set Link Bandwidth Community
Cisco 8000E status
RT-7.5: pending authorization
RT-7.5: BGP Policy - Match and Set Link Bandwidth Community
Cisco XRd status
RT-7.5: pending authorization
RT-7.5: BGP Policy - Match and Set Link Bandwidth Community
Juniper ncPTX status
RT-7.5: pending authorization
RT-7.5: BGP Policy - Match and Set Link Bandwidth Community
Nokia SR Linux status
RT-7.5: pending authorization
RT-7.5: BGP Policy - Match and Set Link Bandwidth Community
Openconfig Lemming status
RT-7.5: pending authorization
RT-7.5: BGP Policy - Match and Set Link Bandwidth Community

Hardware Devices

Device Test Status Test Documentation Raw Log
Arista status
RT-7.5: pending authorization
RT-7.5: BGP Policy - Match and Set Link Bandwidth Community
Cisco status
RT-7.5: pending authorization
RT-7.5: BGP Policy - Match and Set Link Bandwidth Community
Juniper status
RT-7.5: pending authorization
RT-7.5: BGP Policy - Match and Set Link Bandwidth Community
Nokia status
RT-7.5: pending authorization
RT-7.5: BGP Policy - Match and Set Link Bandwidth Community

Help

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request clarifies how BGP import policies are handled across different platforms by replacing an existing deviation with a more descriptive one. It updates the codebase to explicitly distinguish between devices that require an allow-all policy and those that accept routes by default, ensuring more accurate test behavior and configuration management.

Highlights

  • Refactored BGP Import Policy Deviation: Renamed the explicitly_apply_allow_all_import_policy deviation to bgp_default_import_policy_accept_route to better reflect the underlying device behavior regarding implicit route acceptance.
  • Metadata and Protocol Updates: Reserved the old metadata field, added the new field, and updated relevant platform exception configurations.
  • Test Logic Adjustment: Updated the link bandwidth test to conditionally apply an explicit allow-all import policy only when the device does not support implicit route acceptance.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the explicitly_apply_allow_all_import_policy deviation with a new bgp_default_import_policy_accept_route deviation across the codebase, including proto definitions, metadata, tests, and documentation. Feedback on the changes highlights a style guide violation where the newly added deviation accessor function BgpDefaultImportPolicyAcceptRoute in internal/deviations/deviations.go is missing a tracking issue URL in its comment.

Comment thread internal/deviations/deviations.go Resolved

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants