Skip to content

Correct the Workers Builds branch control note #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patshone-gsl merged 2 commits into from
Aug 28, 2026
Merged

Correct the Workers Builds branch control note #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee1cb0a
Correct the branch control note
greenshootbot Jul 29, 2026
b1c2ccb
Merge phase-4/look-and-feel into docs/branch-control-correction
greenshootbot Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions MIGRATION-NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,37 @@ image.

---

## 2026-07-29 — Workers Builds branch control: no per-branch exclusions exist

Correcting earlier guidance in this file and in PR #13, which said to exclude
`documentation`, `3.9` and `release/*` from build triggers. **That capability does not
exist.** Workers Builds' branch control (Overview -> Worker -> Settings -> Build -> Branch
control) offers only two things: a production-branch dropdown, and a single all-or-nothing
checkbox, "Builds for non-production branches".

Non-production builds are currently **enabled**. Evidence: two pushes to
`fix/ci-lockfile-npm-version` each produced a `versions upload` with no deployment, matching
the documented non-production deploy command.

| Commit pushed | Version uploaded |
|---|---|
| `af08648` 12:11:56Z | 12:12:28Z |
| `a2772eb` 12:15:40Z | 12:16:20Z |

So the `documentation` problem is live. Every GitBook sync to that branch triggers a build
that fails at `npm ci`, because the branch has no `package.json`. There is no clean
mitigation: the failure happens at the install step before any command we control runs, and
a `package.json` cannot be added to `documentation` — it is GitBook's, read-only, and writing
to it corrupts the live site.

**Recommendation: disable non-production branch builds.** The reason is alarm fatigue rather
than noise as such — if `documentation` fails several times a day, a real failure on `main`
is lost in the stream. Preview URLs would be convenient for the Phase 4 look-and-feel review,
but are not required: `scripts/screenshots.mjs` points at a local dev server just as well as
at a preview URL. Re-enable for that stretch if it earns its keep.

---

## 2026-07-30 — Phase 2 gate: conversion script complete

`scripts/convert.mjs` and `scripts/sidebar.mjs` are done. 204 pages convert, `astro build`
Expand Down