Fix dragndrop#644
Open
roymacdonald wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drag and drop a folder into PG now works. I only tested it on macos.
Reason (given by claude code):
app.js:914 reads files[0].path. Electron removed the File.path augmentation (deprecated v30, gone by the v32+
line — you're on 35.7.5). So files[0].path is now undefined, and path.normalize(undefined + '/..') produces a garbage
path. The import button is unaffected because it gets real paths from the native dialog in the main process, not from a
File object.
The fix is to use webUtils.getPathForFile(file), which replaces File.path.
The rest is a css fix so the drop zone is over the whole windon and not towards the bottom as it has been for a while.