Skip to content

Add quick chat messages#4347

Draft
AmanorsElliot wants to merge 1 commit into
openfrontio:mainfrom
AmanorsElliot:codex/text-additions
Draft

Add quick chat messages#4347
AmanorsElliot wants to merge 1 commit into
openfrontio:mainfrom
AmanorsElliot:codex/text-additions

Conversation

@AmanorsElliot

@AmanorsElliot AmanorsElliot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a quick chat line for building a SAM site.
  • Add a quick chat line: "Great supine protoplasmic invertebrate jellies". A tasteful, traditional British insult.
  • Add the corresponding English localization strings.

Scope

In-line with the contributor guidelines, this is a simple PR for 2 small text additions. #4348

Validation

  • npm exec vitest run -- tests/EnJsonSorted.test.ts

@CLAassistant

CLAassistant commented Jun 18, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions Bot added the small-fix Small fix (≤ 50 lines) — auto-applied by PR gate label Jun 18, 2026
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Two new quick-chat entries are added: build_sam_site under the defend action list and great_supine_protoplasmic_invertebrate_jellies under the misc action list in QuickChat.json. Both have requiresPlayer: false. Matching English localization strings are added for each in en.json.

Changes

New QuickChat Entries

Layer / File(s) Summary
New defend and misc quick-chat entries with localization
resources/QuickChat.json, resources/lang/en.json
Adds build_sam_site to the defend list and great_supine_protoplasmic_invertebrate_jellies to the misc list, both with requiresPlayer: false. Matching English labels — "Build a SAM site!" and the jellies string — are added in en.json.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🛡️ A SAM site rises, ready to defend,
While jellies wobble from beginning to end,
No player required, just a key and a name,
Two lines in JSON, a small but fine claim.
🪼 The chat menu grows, one glorious phrase at a time!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add quick chat messages' directly and clearly summarizes the main change of adding two new quick chat options to the game.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description clearly explains the additions: two new quick chat lines with corresponding English localization strings, referencing issue #4348 and validation approach.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small-fix Small fix (≤ 50 lines) — auto-applied by PR gate

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants