Skip to content

BrasilData 0.1.15: replacing a layer no longer removes the one that just landed - #48

Open
elpidioassinaturas wants to merge 1 commit into
opengeos:mainfrom
elpidioassinaturas:brasildata-0.1.15
Open

elpidioassinaturas wants to merge 1 commit into
opengeos:mainfrom
elpidioassinaturas:brasildata-0.1.15

Conversation

@elpidioassinaturas

@elpidioassinaturas elpidioassinaturas commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Plugin: BrasilData (brasildata), elpidioassinaturas/BrasilData

What it does: this updates registry/brasildata.json from 0.1.14 to 0.1.15, and nothing else.

How I tested it: python scripts/build.py --check with this entry passes (with Python 3.12): 1 new package, 12 already published. The release's hash matches the entry.

Against real services, with the same source as the release:

The package from the release itself ran the INPE hotspots case in rustgis-cli 0.5.0, with the same result. Solos could not be run with it: see below.

Not tested: the desktop window; the census tracts; in the web app, the case with an area and the theme that makes its own request.

A known failure, not from this version: Solos can fail with no layer 'BDIA:pedo_area', on 0.1.14 too and with a plain service.add with no plugin. IBGE's WFS lists 10,186 layers, their order changes between answers, and RustGIS reads the first 2,000. When it failed, that layer was at position 10,181. It needs a fix in RustGIS.

  • The entry's source.url is a release asset of the plugin's repository, and sha256 is that file's.
  • The plugin asks only for the permissions it uses.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Updates
    • Updated the BrasilData plugin reference from v0.1.14 to v0.1.15 and replaced its SHA-256 checksum with the value for the new release. No other user-facing changes are described in this update.

…ust landed

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The BrasilData registry entry now references plugin release v0.1.15 and its updated SHA-256 checksum.

Changes: BrasilData release metadata

Layer / File(s) Summary
Update release metadata
registry/brasildata.json
The plugin download URL now references v0.1.15. The registry entry also contains the updated SHA-256 checksum.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: Minimal · up to 6244c

The registry update has no identified merge-blocking issue and is mergeable subject to normal release validation.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title identifies the BrasilData release and its layer replacement fix.
Description check Passed The description includes the plugin link, changes, test results, limitations, and required checklist. It does not explain the plugin's general purpose, but is otherwise complete.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the release note,
Then hops beside the checksum quote.
The new version joins the registry line,
Its matching hash is set in time.
One happy hare goes back to dine.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 5df5c3b6-1d09-4cb6-8f40-f2f4603c6159
Commits

Reviewing files that changed from the base of the PR and between e61f0c5 and 6244cf8.

Files selected for processing: 1

  • registry/brasildata.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

Code review

Bugs

  • None found. The diff changes only source.url and source.sha256 in registry/brasildata.json, from v0.1.14 to v0.1.15. The URL is a release asset of the plugin's own repository, and the unpacked manifest reports version 0.1.15 and id brasildata, matching the entry. (high)

Security

  • The module imports only rustgis.log, rustgis.call and rustgis.result, and exports memory, rustgis_alloc and rustgis_call, as required. (high)
  • layer.remove, layer.rename and table.remove are named in strings. This fits the PR's stated fix, which removes and renames layers when a theme is requested again. edit.deleteField is also listed, and I could not check from the compiled module what it removes or when. I have no earlier package to compare, so I can't say whether the command list changed. (medium)
  • I could not read the module's code. The homepage points to https://github.com/elpidioassinaturas/BrasilData, which is where a maintainer can check the source. (medium)

Performance

  • None.

Quality

  • None. The PR description is clear about what was and wasn't tested. The no layer 'BDIA:pedo_area' failure it describes predates this version and is a RustGIS issue.

CLAUDE.md

  • No CLAUDE.md guidelines were found for the changed file. The PR adds only a registry entry update and no plugin source, so it is in scope.

Plugin packages

id version runtime package module permissions module imports commands named in strings
brasildata 0.1.15 wasm 4,848,880 B 6,590,542 B edit, files, network rustgis.log, rustgis.call, rustgis.result edit.addField, edit.calculateField, edit.deleteField, edit.enable, gp.run, host.addLayer, host.features, host.layers, host.notify, host.view, info.project, layer.addUrl, layer.fields, layer.remove, layer.rename, layer.select, layer.template, layer.zoomTo, map.addTiles, map.removeTiles, map.tiles, raster.mosaic, raster.process, select.byAttributes, select.layerFromSelection, service.add, table.remove, tool.set

Assessment of brasildata. The package was downloaded and its hash matched. The edit, files and network permissions fit a plugin that downloads Brazilian public datasets (IBGE, INDE, ANM, INCRA, CAR, BCB Olinda, Copernicus DEM, the GitHub releases API) and adds them to the project.

  • The files permission needs a maintainer's judgment. The plugin appears to fetch and add data layers, but its code can't be read here, so I can't tell which paths it writes.
  • The URLs in module.txt all point at public Brazilian government services, GitHub, and public S3 buckets for Copernicus and OpenTopography.
  • The plugin checks api.github.com/.../releases/latest, so it appears to look for its own updates. That is a network call a maintainer may want to confirm.
  • I found no evidence of anything beyond the described purpose, but the compiled module can't be audited here.

Change size

Compared: the whole PR against main (merge base e61f0c5 to PR head 6244cf8).

Metric Value
Files changed 1 (0 added, 1 modified, 0 removed, 0 renamed)
Size before 275 B
Size after 275 B
Total size change +0 B
File Before After Change
registry/brasildata.json 275 B 275 B +0 B

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

🧩 Plugin preview

Open in RustGIS: web.rustgis.app's Plugin Manager on this pull request's registry (1 plugin package from this pull request). Install from Browse; RustGIS shows the permissions first.

Item Value
Preview https://pr-48.rustgis-plugins-preview.pages.dev
Registry (desktop: Plugin Manager › Settings) https://pr-48.rustgis-plugins-preview.pages.dev/registry.json
This commit https://fd0b9684.rustgis-plugins-preview.pages.dev
Commit 6244cf8

Unreviewed code: install it only to review this pull request.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants