Repository navigation
feat: E2E deployment gate with floors, fixtures, SHA pins - #20
Merged
Merged
Conversation
zhongliang02
approved these changes
Sep 11, 2026
zhongliang02
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test infrastructure only —
codeql-config.ymlis unchanged, so nothing consumers scan changes on merge. Closes Codex NO-GO findings #1, #7, #10.What it adds
gate/— derives the scan matrix from the config's ownpacks:keys, then asserts against this run's SARIF (no baseline filtering): query-count floor (catchesquery-filtersover-excluding) and expected custom rule IDs loaded (catches a pack that installs but skips its queries, or a CLI bump that drops one).gate/config.json— bumping one is a reviewed diff, not a magic number.ci.ymlrewired to run those assertions; alluses:SHA-pinned (also insample-workflow.yml).v1.0.0created ata4c7e5d— the rollback point.Evidence
Before you merge
actions:packs key (strict-derive, per operator decision). In that window the dailycodeql-action-testingcanary is the only Actions watch. Merge feat: E2E deployment gate with floors, fixtures, SHA pins #20, then feat: add actions-custom-queries@1.1.2 to central config #19.Deployment gateas a required status check on theprodruleset (2894624) — separate click.query-filtersexcludeactions/missing-workflow-permissions); post-feat: add actions-custom-queries@1.1.2 to central config #19 it becomes 19 (16 + 3 custom), not 20. Don't "fix" it back.