Repository navigation
Missing CV-X-IF result address register x_result_i.rd assignation for writeback instructions - #343
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused change aligns destination-address and write-data routing, with no unresolved findings.
0 open findings
What changed in this PR
Fixes CV-X-IF writeback destination selection, addressing #341.
Changes:
- Uses
x_result_i.rdfor CV-X-IF coprocessor writeback. - Preserves the decoded destination for other writeback paths.
| File | Description |
|---|---|
| rtl/cve2_id_stage.sv | Adds a destination-address mux aligned with write-data selection. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
MikeOpenHWGroup
left a comment
MikeOpenHWGroup
left a comment
There was a problem hiding this comment.
Thanks for this PR @anecorral. Please have a look at my comment.
Also, you must sign the Eclipse Contributor Agreement before we can accept a PR. Please have a look at CONTRIBUTING.md for the details.
|
Thanks @anecorral, this looks good and passes our verification regression (with XInterface set to '0). This change will break equivalence, so I have deliberately not launched the workflows. |
As discussed in #341.