If std descriptor is bound with regular file, redirect it to pseudo terminal before the checkpoint

[Larry-N]

CRIU restore fail after Checkpoint stdout to file.
Redirecting a stdout to the pipeline doesn't break the restore.

A proposed approach forces the close of stdout, stdin, and stderr file descriptors if they are redirected to the files, on checkpoint resources verification.

---

Progress

• Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/24/head:pull/24
$ git checkout pull/24

Update a local copy of the PR:
$ git checkout pull/24
$ git pull https://git.openjdk.org/crac.git pull/24/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24

View PR using the GUI difftool:
$ git pr show -t 24

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/crac/pull/24.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back inakonechnyy! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Larry-N This change is no longer ready for integration - check the PR body for details.

[mlbridge]

Webrevs

• 01: Full - Incremental (c3347ad3)
• 00: Full (6cf8cb99)

[rvansa]

Hi @Larry-N could you accompany the fix with a test case that would demonstrate it?

[openjdk]

@Larry-N this pull request can not be integrated into crac due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout stdout-restore
git fetch https://git.openjdk.org/crac.git crac
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge crac"
git push

[rvansa]

Hi @Larry-N do you intend to work on this any further?

[rvansa]

Closing this; the underlying problem is in CRIU and should be fixed in CRaC/criu#13 . This PR should be superseded by test-only #132 .