Skip to content

8365861: test/jdk/sun/security/pkcs11/Provider/ tests skipped without SkippedException - #3238

Open
tkiriyama wants to merge 2 commits into
openjdk:masterfrom
tkiriyama:backport_8365861
Open

8365861: test/jdk/sun/security/pkcs11/Provider/ tests skipped without SkippedException#3238
tkiriyama wants to merge 2 commits into
openjdk:masterfrom
tkiriyama:backport_8365861

Conversation

@tkiriyama

@tkiriyama tkiriyama commented Jul 9, 2026

Copy link
Copy Markdown
Member

Hi all,

I will backport DK-8365861 from JDK 26 to JDK 11 to address an issue where, when a SunPKCS11 provider is not available, tests would print a skipping message and return. This caused jtreg to misleadingly mark them as "Passed" because no explicit failure occurred. In other words, when PKCS#11 functionality was unavailable, the tests exited normally and were counted the same as successful tests, even though they did not actually verify any functionality.

This backport is mostly clean from JDK 17, but some manual fixes are required.

Unclean Backport
The backport of JDK-8365861 to JDK 11 is not straightforward because ConfigShortPath.java differs from the version targeted by the original fix. In particular, JDK 11 still contains Solaris-related code that was later removed in JDK 15 as part of JDK-8244224. Since that removal is not planned for backporting to JDK 11 or earlier releases, the affected sections of ConfigShortPath.java do not align cleanly with the upstream patch and require manual edits.

There are additional, similar PKCS#11 test improvements in newer releases, but we plan to backport those to JDK 11 separately and in due course.

Thank you.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8365861 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8365861: test/jdk/sun/security/pkcs11/Provider/ tests skipped without SkippedException (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3238/head:pull/3238
$ git checkout pull/3238

Update a local copy of the PR:
$ git checkout pull/3238
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3238/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3238

View PR using the GUI difftool:
$ git pr show -t 3238

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3238.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jul 9, 2026

Copy link
Copy Markdown

👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 9, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title backport 969eb1ce2419324582ee8d8108031323f82e125e 8365861: test/jdk/sun/security/pkcs11/Provider/ tests skipped without SkippedException Jul 9, 2026
@openjdk

openjdk Bot commented Jul 9, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added the backport Port of a pull request already in a different code base label Jul 9, 2026
@openjdk openjdk Bot added the rfr Pull request is ready for review label Jul 9, 2026
@mlbridge

mlbridge Bot commented Jul 9, 2026

Copy link
Copy Markdown

Webrevs

@bridgekeeper

bridgekeeper Bot commented Aug 6, 2026

Copy link
Copy Markdown

@tkiriyama This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper

bridgekeeper Bot commented Sep 3, 2026

Copy link
Copy Markdown

@tkiriyama This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper Bot closed this Sep 3, 2026
@tkiriyama

Copy link
Copy Markdown
Member Author

/open

@openjdk openjdk Bot reopened this Sep 3, 2026
@openjdk

openjdk Bot commented Sep 3, 2026

Copy link
Copy Markdown

@tkiriyama This pull request is now open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant