8365861: test/jdk/sun/security/pkcs11/Provider/ tests skipped without SkippedException - #3238
8365861: test/jdk/sun/security/pkcs11/Provider/ tests skipped without SkippedException#3238tkiriyama wants to merge 2 commits into
Conversation
… SkippedException
|
👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
… SkippedException
|
@tkiriyama This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
@tkiriyama This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
|
/open |
|
@tkiriyama This pull request is now open |
Hi all,
I will backport DK-8365861 from JDK 26 to JDK 11 to address an issue where, when a SunPKCS11 provider is not available, tests would print a skipping message and return. This caused jtreg to misleadingly mark them as "Passed" because no explicit failure occurred. In other words, when PKCS#11 functionality was unavailable, the tests exited normally and were counted the same as successful tests, even though they did not actually verify any functionality.
This backport is mostly clean from JDK 17, but some manual fixes are required.
Unclean Backport
The backport of JDK-8365861 to JDK 11 is not straightforward because ConfigShortPath.java differs from the version targeted by the original fix. In particular, JDK 11 still contains Solaris-related code that was later removed in JDK 15 as part of JDK-8244224. Since that removal is not planned for backporting to JDK 11 or earlier releases, the affected sections of ConfigShortPath.java do not align cleanly with the upstream patch and require manual edits.
There are additional, similar PKCS#11 test improvements in newer releases, but we plan to backport those to JDK 11 separately and in due course.
Thank you.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3238/head:pull/3238$ git checkout pull/3238Update a local copy of the PR:
$ git checkout pull/3238$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3238/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3238View PR using the GUI difftool:
$ git pr show -t 3238Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3238.diff
Using Webrev
Link to Webrev Comment