Preprint authors use the journal FrozenAuthor system; updates are moderated drafts

[ajrbyers]

Moves preprint authors from PreprintAuthor (one row per linked account) to the journal FrozenAuthor model, and makes author-submitted updates moderated drafts.

What changed

Authors

• Preprint authors are FrozenAuthor rows on the preprint, with ROR affiliations (ControlledAffiliation) and CRediT roles, as for articles. Authors no longer need an account.
• Submitting authors and moderators edit authors with the journal author pages (add, link by email, reorder, remove, affiliations).
• Each superseded version keeps its own author list and custom field answers.
• Crossref deposits and OAI records output the FrozenAuthors and their organisations.
• Account merges carry over preprint, update and version author lists.

Moderated updates

• A new version, correction or metadata correction starts as a draft holding a full copy of the preprint's metadata: title, abstract, DOI, authors and custom fields. The author edits and submits it.
• On approval, only the sections the author changed replace the live ones, so moderator edits made in the meantime are kept. There is one open update per preprint.
• The version queue loads each update's details in a pop-up (htmx) showing the changes, with a warning naming any sections that changed since the draft started.
• Draft, author and approval edits are locked (select_for_update) so concurrent changes can't be lost.

API

• Preprint authors read and write FrozenAuthors. Field names are unchanged; pk is the linked account's ID, if any.
• version_queue accepts authors and additional_field_answers and reports the changed sections.
• ?search= on the manager preprint API works again and stays within the current repository.

Upgrading

• Migrations: repository 0060–0062, submission 0093–0094, core 0116.
• repository 0061 copies every PreprintAuthor onto its preprint as a FrozenAuthor, with affiliations, CRediT records and order. repository 0062 then deletes PreprintAuthor.
• Back up before migrating. The migrations can be reversed, but the reverse only restores authors who have an account, and drops the author lists of superseded versions. Rolling back after authors have been edited loses data.

Follow-ups

• Stacked on this: Each preprint version has its own page #5621 (a page for each version) and Split repository moderators from managers #5622 (repository moderators).

[mauromsl]

One thing I've noticed inline. I've also already merged #5618 so might be worth rebasing

[mauromsl]

This copying pattern in django can be a bit dangerous, as it is mutating an object in memory (even tho it does the trick). It would be safer to use django.forms.models.model_to_dict. e.g, if we add a new m2m relationship to this model, tests will fail when using model_to_dict whilst the mutation done here would silently drop those relations.

[ajrbyers]

Thanks, switched to model_to_dict in d7b9674. There is a new core.model_utils.copy_instance(instance, **fields) that builds the copy from model_to_dict, so a many-to-many field added later raises a TypeError instead of being dropped. FrozenAuthor.copy() and RepositoryFieldAnswer.copy() both use it, with a test for each case.

[mauromsl]

I believe these might be easier to do with the model_to_dict too, since they become a list of pks

[ajrbyers]

Done in the same commit: affiliations and CRediT records are built with copy_instance too. Affiliations still go through bulk_create, as ControlledAffiliation.save() would make the first copy primary. Also rebased on r-v1.9.x with #5618 in; the repository migrations are now 0060–0062.