Skip to content

Skip libmoq's CMake package exports when embedding it - #97

Closed
zshenker wants to merge 1 commit into
openmoq:mainfrom
zshenker:fix/libmoq-package-exports
Closed

zshenker wants to merge 1 commit into
openmoq:mainfrom
zshenker:fix/libmoq-package-exports

Conversation

@zshenker

@zshenker zshenker commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Problem

The Build and test (ubuntu-latest, libmoq) job has failed at CMake generate on every PR since 2026-10-28:

CMake Error in build/_deps/moq5-src/adapters/picoquic/CMakeLists.txt:
  export called with target "moq-adapter-picoquic" which requires target
  "picoquic-core" that is not in any export set.

moqxr fetches moq5 at main. Between the last green run (moq5 777edf57) and the first red one (f528eba4), moq5 merged bac37c63 "Export CMake component configurations". Since then each adapter exports its targets whenever MOQ_BUILD_PACKAGE_EXPORTS is on, which is the default. The adapters link the picoquic targets that moqxr adds itself, and those targets are in no export set. The runner's CMake version (3.31.6) didn't change between the two runs.

Change

Force MOQ_BUILD_PACKAGE_EXPORTS OFF alongside the other libmoq options moqxr sets. moqxr links libmoq's targets in-tree and installs no CMake package of its own (see the note above its install rules), so it doesn't use libmoq's package.

Testing

With OPENMOQ_USE_LIBMOQ_PUBLISHER=ON against moq5 f81a6188, the current main, configure succeeds and ctest passes 28/28. The default build is unaffected, because it doesn't configure libmoq.

A separate question, not addressed here: should moqxr pin moq5 to a commit instead of following main?

🤖 Generated with Claude Code


This change is Reviewable

libmoq now exports each adapter's targets whenever
MOQ_BUILD_PACKAGE_EXPORTS is on, its default. The adapters link the
picoquic targets this project adds, which are in no export set, so
configuring with OPENMOQ_USE_LIBMOQ_PUBLISHER=ON fails at the generate
step. moqxr links libmoq in-tree and installs no CMake package of its
own, so it needs no libmoq package either: turn the exports off.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zshenker added a commit to zshenker/moqxr that referenced this pull request Nov 2, 2026
@gwendalsimon

Copy link
Copy Markdown
Collaborator

Thanks Zac. I opened openmoq/moq5#64 for the same break. It makes MOQ_BUILD_PACKAGE_EXPORTS default to OFF when moq5 is a subdirectory. Every embedding project then builds again without a change on its side. #97 unblocks moqxr's CI now, independently of #64. Once #64 merges, the line in #97 becomes redundant but harmless.

@mondain

mondain commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

Thanks @zshenker. This is included in #104, which integrates the open PRs into one branch. Your commits are kept with your authorship.

Included unchanged. Could not confirm that MOQ_BUILD_PACKAGE_EXPORTS exists at the pinned libmoq.

Closing in favour of #104.

@mondain mondain closed this Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants