Repository navigation
Conversation
libmoq now exports each adapter's targets whenever MOQ_BUILD_PACKAGE_EXPORTS is on, its default. The adapters link the picoquic targets this project adds, which are in no export set, so configuring with OPENMOQ_USE_LIBMOQ_PUBLISHER=ON fails at the generate step. moqxr links libmoq in-tree and installs no CMake package of its own, so it needs no libmoq package either: turn the exports off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zshenker
added a commit
to zshenker/moqxr
that referenced
this pull request
Nov 2, 2026
Collaborator
|
Thanks Zac. I opened openmoq/moq5#64 for the same break. It makes |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Build and test (ubuntu-latest, libmoq)job has failed at CMake generate on every PR since 2026-10-28:moqxr fetches moq5 at
main. Between the last green run (moq5777edf57) and the first red one (f528eba4), moq5 mergedbac37c63"Export CMake component configurations". Since then each adapter exports its targets wheneverMOQ_BUILD_PACKAGE_EXPORTSis on, which is the default. The adapters link the picoquic targets that moqxr adds itself, and those targets are in no export set. The runner's CMake version (3.31.6) didn't change between the two runs.Change
Force
MOQ_BUILD_PACKAGE_EXPORTS OFFalongside the other libmoq options moqxr sets. moqxr links libmoq's targets in-tree and installs no CMake package of its own (see the note above its install rules), so it doesn't use libmoq's package.Testing
With
OPENMOQ_USE_LIBMOQ_PUBLISHER=ONagainst moq5f81a6188, the currentmain, configure succeeds andctestpasses 28/28. The default build is unaffected, because it doesn't configure libmoq.A separate question, not addressed here: should moqxr pin moq5 to a commit instead of following
main?🤖 Generated with Claude Code
This change is