Skip to content

sync: upstream moxygen d2b9e54b4c15 - #632

Merged
omoq-sync-bot[bot] merged 6 commits into
mainfrom
sync/d2b9e54b4c15
Nov 19, 2026
Merged

omoq-sync-bot[bot] merged 6 commits into
mainfrom
sync/d2b9e54b4c15

Conversation

@omoq-sync-bot

@omoq-sync-bot omoq-sync-bot Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Automated upstream sync.

  • Upstream commit: d2b9e54b4c15
  • Upstream status: success (green)
  • Merge type: git merge (sync/d2b9e54b4c15 → main)

The verify workflow will validate the standalone build. On success, this PR auto-merges.
Devs can push conflict-resolution commits to sync/d2b9e54b4c15 if needed.

Created by omoq-upstream-sync workflow.


This change is Reviewable

sandarsh and others added 6 commits November 18, 2026 04:27
Summary: `--lane_manager` gives each client session a `MoQLaneRouter` over the proxy, so `<name>--abr-video` and `<name>--abr-audio` are served from the broadcast's lanes. Policies come from `ScriptedPolicy` until a production policy plugs into the same factory; `--lane_max_wait_ms` (default 100) is the switch wait. Off by default.

Reviewed By: timmboettger

Differential Revision: D129822545

fbshipit-source-id: 0b9c23208e345bd23f9b3af7aa7d094191aba56c
Summary:
MoQServer sets the ContinuousMemory data path, which is already the mvfst default. mvfst is removing the data path setting, so the line goes away. Behavior does not change.

___

landed-with-radar-review

Differential Revision: D131834059

fbshipit-source-id: a24958b6db4599a87237ecf2656d49c7447b5b26
Summary:
Map `xplat/pki/ossdata/export_proxygen` into `proxygen/lib/ssl/trustbundle` in the getdeps source tree so CMake can read `MozillaRoots.pem`.

This fixes the missing bundle in the `oss-proxygen-linux-getdeps` for V1 of D132201872: https://www.internalfb.com/sandcastle/workflow/418834765369443999

Reviewed By: mingtaoy

Differential Revision: D132329380

fbshipit-source-id: 7441d1960435de72d9a80ace8c9e22f7a6e5e728
Summary:
`--shared-lib` (meta/CacheLib#491) appends `-Wl,--exclude-libs=ALL` by defining `CMAKE_SHARED_LINKER_FLAGS` and `CMAKE_MODULE_LINKER_FLAGS` on the cmake command line. A cache variable given on the command line is never seeded from `$LDFLAGS`, so the caller's linker flags silently vanished from every shared library link, while the executables (whose `CMAKE_EXE_LINKER_FLAGS` we leave alone) kept them.

Seed both variables from `$LDFLAGS`, as CMake itself would, before appending. An explicit caller-supplied value still wins.

## How it showed up

Fedora package build of cachelib with `--shared-lib`, `LDFLAGS` set by rpm's `%set_build_flags`. From the generated `build.ninja`:

```
# executable: cachebench
LINK_FLAGS = -Wl,-z,relro -Wl,--as-needed -Wl,-z,pack-relative-relocs -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld ...

# shared library: libcachelib_common.so.19.1.0
LINK_FLAGS = -shared -Wl,--exclude-libs=ALL -Wl,--dependency-file=...
```

The libraries lost RELRO, BIND_NOW and, on Fedora Rawhide, `--error-rwx-segments`. That last one would have turned a real problem into a link error: fbthrift's generated `_data.cpp` files put relocated data in a `.rodata.*` section, which `-fPIC` makes writable, so every `libcachelib_*.so` was linked with a single RWX LOAD segment (ld only warned) and glibc's aarch64 loader then crashed on them at startup. With this fix the hardening flags reach the `.so` links and that class of problem fails loudly at link time.

X-link: meta/CacheLib#499

Reviewed By: pbhandar2

Differential Revision: D121223688

Pulled By: rlyerly

fbshipit-source-id: ff0d656763de8011f8676674e2e8fddb3c238373
Summary: `MoQServer`'s WebTransport handler compared `:protocol` against `webtransport` itself. It now calls `HTTPWebTransport::isConnectMessage`, so it follows it when it accepts more upgrade tokens. No behavior change on its own.

Reviewed By: afrind

Differential Revision: D132963049

fbshipit-source-id: 9eb3f5fb6c113d825be7bc985dfcdc69217c9912

@gmarzot gmarzot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by upstream sync workflow.

@coderabbitai

coderabbitai Bot commented Nov 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@omoq-sync-bot
omoq-sync-bot Bot merged commit 97d26a3 into main Nov 19, 2026
3 checks passed
@omoq-sync-bot
omoq-sync-bot Bot deleted the sync/d2b9e54b4c15 branch November 19, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants