Repository navigation
sync: upstream moxygen 22dbc79b4a57 - #634
Open
omoq-sync-bot[bot] wants to merge 6 commits into
Open
omoq-sync-bot[bot] wants to merge 6 commits into
omoq-sync-bot[bot] wants to merge 6 commits into
Conversation
Summary: Allow applications to track active server sessions through a configurable statistics callback, following the existing statistics interfaces. Pair begin and end events across normal closure and error paths, and wire the server integration to export the current session count. Reviewed By: kvtsoy Differential Revision: D132943723 fbshipit-source-id: 29db1f0acf7bd9a43922ffba00cef4bf2e2ec67b
Summary: GitHub commits: WhatsApp/erlang-language-platform@1137af7 facebookexperimental/edencommon@e2a8579 facebookexperimental/rust-shed@14e51a5 facebookincubator/fizz@6c95d45 meta/CacheLib@b96dbfe meta/fb303@0933fc8 meta/fbthrift@5c69d38 meta/folly@24e09e9 meta/hermes@189b124 meta/meta-haptics-sdk@80d053a meta/mvfst@84a6f11 meta/proxygen@1067488 meta/wangle@d9817a7 pyrefly-org/pyrefly@9c065d5 Reviewed By: ajb85 fbshipit-source-id: 71d64d25c9ade10bab53bffc442a0259a001ccb6
Summary: The frame type sets and the parameter allowlist in `MoQTypes.cpp` were namespace-scope `F14` containers, constructed at load time. Apple builds flag that with `-Wglobal-constructors`. They are now accessor functions that return function-local statics, and the lookups call them. Part of making Apple builds clean for `-Wglobal-constructors` (T298219509). ___ landed-with-radar-review Differential Revision: D133285618 fbshipit-source-id: b3fce52c926288ff9215fed0af62a6bd4f67fa27
Summary: Makes getdeps keep its git fetch of a pinned revision shallow. One line in `GitFetcher._update()` (`build/fbcode_builder/getdeps/fetcher.py`): the `git fetch origin <rev>` now gets the same `--depth` the clone already uses. **Why.** `GitFetcher` clones with `--depth=1`, which gets the tip of the default branch. When the wanted revision is not that tip, it then runs `git fetch origin <rev>` with no depth. The shallow clone holds only the unrelated tip commit, so git downloads the entire ancestry of `<rev>`. The repository still reports itself as shallow, which hides the problem. Every project pinned through a manifest `rev` or a `build/deps/github_hashes` file takes this path: folly, fizz, mvfst, wangle, fbthrift, fb303, glog, libevent and others. On a slow connection this is costly: we have seen a single fbthrift fetch run for over an hour and fail after 283 MB. **Does anything need the history?** I looked for it and found nothing: - getdeps itself only runs `rev-parse`, `checkout`, `submodule update --init`, `git apply` (patches) and `git clean` on these checkouts. `GitFetcher.hash()` returns the rev string. - `_git_describe_version()` in `cli.py` (version of a vendored tree) already assumes shallow clones and deepens by 250 commits, up to four times, until `git describe` finds a tag. - `is_public_commit()` uses `merge-base`, but on the repository being built, not on dependency checkouts. - Build systems of the checked-out dependencies (fatal, fb303, fbthrift, folly, mvfst, wangle, fizz, double-conversion, glog, libevent): the only one that asks git about history is libevent's `VersionViaGit.cmake` (`git describe --abbrev=0 --always`). It already falls back to its built-in version today, because fetching a pinned SHA brings no tags. **Things reviewers should know** - The change is deliberately minimal. The clone still downloads the branch tip before fetching the pin. Removing that would mean restructuring `_clone()`, for a smaller gain. - An existing scratch dir keeps whatever history it already has; only new fetches are shallow. X-link: meta/fboss#1977 Reviewed By: AarjunC Differential Revision: D133356416 Pulled By: KevinYakar fbshipit-source-id: bdbb580043547777309d4ac8c5c7dedf13b73e64
Summary: Expose `recordUpstreamTimeToFirstSubscribeObject` and `recordUpstreamTimeToFirstFetchObject` through `MoQProxy` statistics as pure virtual callbacks that implementations must supply. Record elapsed milliseconds for each upstream request when its first data object starts arriving, with a fresh sample for retries and replacement requests. Responses served entirely from cache do not produce upstream samples. Reviewed By: kvtsoy Differential Revision: D132967427 fbshipit-source-id: b6b613d9411ce57c271134b3281a2463dea731ee
gmarzot
approved these changes
Nov 20, 2026
gmarzot
left a comment
Collaborator
There was a problem hiding this comment.
Auto-approved by upstream sync workflow.
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated upstream sync.
22dbc79b4a57The verify workflow will validate the standalone build. On success, this PR auto-merges.
Devs can push conflict-resolution commits to
sync/22dbc79b4a57if needed.Created by
omoq-upstream-syncworkflow.This change is