Skip to content

sync: upstream moxygen 22dbc79b4a57 - #634

Open
omoq-sync-bot[bot] wants to merge 6 commits into
mainfrom
sync/22dbc79b4a57
Open

omoq-sync-bot[bot] wants to merge 6 commits into
mainfrom
sync/22dbc79b4a57

Conversation

@omoq-sync-bot

@omoq-sync-bot omoq-sync-bot Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Automated upstream sync.

  • Upstream commit: 22dbc79b4a57
  • Upstream status: success (green)
  • Merge type: git merge (sync/22dbc79b4a57 → main)

The verify workflow will validate the standalone build. On success, this PR auto-merges.
Devs can push conflict-resolution commits to sync/22dbc79b4a57 if needed.

Created by omoq-upstream-sync workflow.


This change is Reviewable

sharmafb and others added 6 commits November 19, 2026 09:31
Summary: Allow applications to track active server sessions through a configurable statistics callback, following the existing statistics interfaces. Pair begin and end events across normal closure and error paths, and wire the server integration to export the current session count.

Reviewed By: kvtsoy

Differential Revision: D132943723

fbshipit-source-id: 29db1f0acf7bd9a43922ffba00cef4bf2e2ec67b
Summary:
The frame type sets and the parameter allowlist in `MoQTypes.cpp` were namespace-scope `F14` containers, constructed at load time. Apple builds flag that with `-Wglobal-constructors`. They are now accessor functions that return function-local statics, and the lookups call them.

Part of making Apple builds clean for `-Wglobal-constructors` (T298219509).

___

landed-with-radar-review

Differential Revision: D133285618

fbshipit-source-id: b3fce52c926288ff9215fed0af62a6bd4f67fa27
Summary:
Makes getdeps keep its git fetch of a pinned revision shallow. One line in `GitFetcher._update()` (`build/fbcode_builder/getdeps/fetcher.py`): the `git fetch origin <rev>` now gets the same `--depth` the clone already uses.

**Why.** `GitFetcher` clones with `--depth=1`, which gets the tip of the default branch. When the wanted revision is not that tip, it then runs `git fetch origin <rev>` with no depth. The shallow clone holds only the unrelated tip commit, so git downloads the entire ancestry of `<rev>`. The repository still reports itself as shallow, which hides the problem. Every project pinned through a manifest `rev` or a `build/deps/github_hashes` file takes this path: folly, fizz, mvfst, wangle, fbthrift, fb303, glog, libevent and others. On a slow connection this is costly: we have seen a single fbthrift fetch run for over an hour and fail after 283 MB.

**Does anything need the history?** I looked for it and found nothing:

- getdeps itself only runs `rev-parse`, `checkout`, `submodule update --init`, `git apply` (patches) and `git clean` on these checkouts. `GitFetcher.hash()` returns the rev string.
- `_git_describe_version()` in `cli.py` (version of a vendored tree) already assumes shallow clones and deepens by 250 commits, up to four times, until `git describe` finds a tag.
- `is_public_commit()` uses `merge-base`, but on the repository being built, not on dependency checkouts.
- Build systems of the checked-out dependencies (fatal, fb303, fbthrift, folly, mvfst, wangle, fizz, double-conversion, glog, libevent): the only one that asks git about history is libevent's `VersionViaGit.cmake` (`git describe --abbrev=0 --always`). It already falls back to its built-in version today, because fetching a pinned SHA brings no tags.

**Things reviewers should know**

- The change is deliberately minimal. The clone still downloads the branch tip before fetching the pin. Removing that would mean restructuring `_clone()`, for a smaller gain.
- An existing scratch dir keeps whatever history it already has; only new fetches are shallow.

X-link: meta/fboss#1977

Reviewed By: AarjunC

Differential Revision: D133356416

Pulled By: KevinYakar

fbshipit-source-id: bdbb580043547777309d4ac8c5c7dedf13b73e64
Summary: Expose `recordUpstreamTimeToFirstSubscribeObject` and `recordUpstreamTimeToFirstFetchObject` through `MoQProxy` statistics as pure virtual callbacks that implementations must supply. Record elapsed milliseconds for each upstream request when its first data object starts arriving, with a fresh sample for retries and replacement requests. Responses served entirely from cache do not produce upstream samples.

Reviewed By: kvtsoy

Differential Revision: D132967427

fbshipit-source-id: b6b613d9411ce57c271134b3281a2463dea731ee

@gmarzot gmarzot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by upstream sync workflow.

@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants