Repository navigation
Develop - #5
Merged
Merged
Develop#5
Conversation
Add a "Service Options" group to the Stream settings page that renders a service's own properties, so that a plugin can expose its settings without requiring frontend changes. obsproject#12911 makes a plugin's service appear in the services dropdown, but the Stream page could still only configure Server and Stream Key. A service with settings of its own had nowhere to put them in the UI, leaving plugins with the problem obsproject#12911 solves for discovery: editing OBSBasicSettings_Stream.cpp to hardcode new fields. The group is only shown for a plugin-provided service that declares at least one property the Stream page does not already own. Properties named after keys the page writes itself are removed, so that they cannot appear twice or overwrite what the page saves. On save, the property values are written to the service settings together with their defaults, as explicit values. This is needed because, unlike outputs, services do not have get_defaults applied on creation, so the plugin would otherwise receive empty fields in create(). The trade-off is that defaults are frozen once the user saves: changing a default in a later version of a plugin does not reach users who already have settings stored.
Add a "low_latency" encoder setting, not exposed in the UI, that services can enable through apply_encoder_settings for real-time protocols. On hardware H.264/HEVC encoders it creates the session with EnableLowLatencyRateControl, which selects the low latency (.rtvc) encoder, and sets RealTime. CBR falls back to ABR and Spatial AQ is skipped, as neither is supported in this mode. Other encoders ignore the setting and encode normally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is