Skip the Nextflow resource label check for workflow components - #41
Merged
Merged
Conversation
* check_config: only check the nextflow runner directives when the component is not a nextflow_script component * add tests for the nextflow runner checks * update changelog
rcannood
added a commit
to openproblems-bio/task_predict_modality
that referenced
this pull request
Jul 29, 2026
* they are inert on a nextflow_script component, viash renders a workflow instead of a process * remove them once openproblems-bio/core#41 is released
rcannood
added a commit
to openproblems-bio/task_predict_modality
that referenced
this pull request
Jul 29, 2026
* run check_config on methods too * Add check_config.py to comp_method.yaml's test resources * Move documentation_url/repository_url to links in the four configs that still used the old placement * Give novel and simple_mlp a nextflow resource label Control methods and metrics were checked, methods were not, which is how the deprecated info.documentation_url survived in four configs. * mark the nextflow labels on novel and simple_mlp as placeholders * they are inert on a nextflow_script component, viash renders a workflow instead of a process * remove them once openproblems-bio/core#41 is released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
check_config()requires every method, control method and metric to carrytime,memandcpulabels on its Nextflow runner. That check does not apply to a component whose script is itself a Nextflow workflow -- Viash renders those as a workflow rather than a process, so there is nothing for the labels to attach to.Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!