Read the task commit from task_info.yaml - #943
Open
rcannood wants to merge 1 commit into
Open
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
get_task_infohardcoded the commit, so everytask_info.jsonwe have everpublished carries
"commit": null:It now reads the field:
The
%||%is there for the null rather than as a placeholder --unbox(NULL)serialises to
{}, notnull, so dropping it entirely would change the shape ofthe output for every task that does not write the field yet:
A task that does not supply a commit keeps emitting
null, which is exactly what itdoes today -- no
"missing-sha"placeholder, since a gap here should be fixed inwhatever generated the results rather than papered over.
The other half is in the task repos:
run_benchmarkhas to writeworkflow.commitIdinto
task_info.yaml. openproblems-bio/task_spatial_simulators#33 does that, and Iwill send the same to
task_template.Issue ticket number and link
Closes #942
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!