Stop copying train_mod2 into novel's model artifact - #47
Merged
Conversation
novel_predict only reads uns from that file -- modality, model_dim and removed_vars -- so there's no reason to carry the expression matrix, obs and var along with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
novel_trainwrites a full copy of the training target into its model directory:but
novel_predictonly ever touchesunson it:so the matrix, obs and var are written, published and re-read for nothing. Keeping just the
uns:The fixture is small enough that h5ad overhead dominates; on the real datasets this is the difference between carrying a full expression matrix per model and not.
I did consider having
novel_predictread--input_train_mod2directly -- the wrapper already passes it -- but that argument is optional incomp_method_predict.yaml, so the model artifact staying self-describing seemed safer.Part of a series of PRs coming out of a pre-run review of the benchmark.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!