FIX: Rotate HRRR grid-relative winds to true north before use as constraint - #163
Merged
Conversation
…traint HRRR u/v are defined relative to its Lambert Conformal Conic grid, not true north. Apply the standard WRF/NCEP grid-rotation correction using the projection's cone factor before interpolating onto the analysis grid. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 70.45% 70.49% +0.04%
==========================================
Files 32 32
Lines 5330 5355 +25
==========================================
+ Hits 3755 3775 +20
- Misses 1575 1580 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Uses the bundled HRRR/RUC sample GRIB2 file to verify add_hrrr_constraint_to_grid's true-north correction meaningfully changes u/v away from the central meridian while conserving wind speed, as a rotation must. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HRRR u/v are defined relative to its Lambert Conformal Conic grid, not true north. This fix has PyDDA apply the correction to true north on the inputs automatically.