Repository navigation
bugfix: validate array variables before use. - #21
Merged
Merged
Conversation
Store array values as references containing a module tag and an array pointer. Check the reference size and tag before mapping or joining, and copy references safely from potentially unaligned NDK buffers. Keep validation independent of the number of arrays in the request. Preserve copied references and arrays used across internal redirects, named locations, and subrequests. Reject overflowing initial capacities and format variable values correctly in error logs. Add regression coverage for invalid scalars, invalid tags, copied references, array lifetimes, and creation of many arrays. All 78 assertions pass against the nginx 1.31.8 test build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register arrays in the request pool and validate variable headers against registered arrays before mapping or joining. Preserve copied headers and arrays used across internal redirects, named locations, and subrequests.
Report invalid scalar arguments with the correct directive name and variable value.
Add regression coverage for invalid scalar handling and array lifetimes. All 67 tests pass against the nginx 1.31.8 test build.