fix: Revert change to write_timestamp - #422
Closed
rebkwok wants to merge 1 commit into
Closed
Conversation
This was changed due to ruff rule SIM115, which flagged that a context manager should be used to write to the timestamp file. However, on windows, writing to a file while there's already an open handle to it _sometimes_ errors. The tests passed, but a user has encountered the error now. Revert the code, add the relevant noqas, and a comment so we don't inadvertently undo this again in future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was changed due to ruff rule SIM115, which flagged that a context manager should be used to write to the timestamp file. However, on windows, writing to a file while there's already an open handle to it sometimes errors. The tests passed, but a user has encountered the error now.
Revert the code, add the relevant noqas, and a comment so we don't inadvertently undo this again in future.