Skip to content

fix: Revert change to write_timestamp #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rebkwok merged 1 commit into from
Aug 12, 2026
Merged

fix: Revert change to write_timestamp #423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions opensafely/jobrunner/executors/volumes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,18 @@ def delete_volume(job):
docker.delete_volume(docker_volume_name(job))

def write_timestamp(job, path, timeout=None):
with tempfile.NamedTemporaryFile() as f:
p = Path(f.name)
# Note: writing to a temporary file while there's already a handle open to it
# is fine on unix, but sometimes errors on Windows, so we use a temp directory
# here instead of opening/writing to a temp file directly.
with tempfile.TemporaryDirectory() as tmpdir:
p = Path(tmpdir) / "timestamp"
p.write_text(str(time.time_ns()))
docker.copy_to_volume(docker_volume_name(job), p, path, timeout)
docker.copy_to_volume(
docker_volume_name(job),
p,
path,
timeout,
)

def read_timestamp(job, path, timeout=None):
return docker.read_timestamp(docker_volume_name(job), path, timeout)
Expand Down