chore: release v1.3.2 and require version bumps per issue - #13
Merged
Conversation
PR 12 merged the plugin half of explorer#402 without touching the version. npm-publish runs on every push to main, but pnpm publish skips a version already on the registry without failing, so the run went green and npm still serves 1.3.1 without the fix. Document that a branch changing packages/plugin/ bumps the package version in a final vX.Y.Z commit, and that every resolved issue ends in a pull request against upstream main: in full in CLAUDE.md, and the version bump in CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs openscan-explorer/explorer#402
Why
#12 merged the plugin half of openscan-explorer/explorer#402 (trimmed build info, hardened artifact injection) without bumping the package version.
npm-publish.ymlruns on every push tomain, butpnpm publishskips a version that is already on the registry without failing. The run on50b04cewent green, and npm still serves1.3.1without the fix.Changes
v1.3.2bumpspackages/plugin/package.jsonfrom1.3.1to1.3.2, so merging this publishes the fix(plugin): keep injected artifacts within the localStorage quota #12 fix.Release rules document the two steps that close out every resolved issue, so an unreleased merge doesn't happen again:
packages/plugin/bumpsversionin itspackage.json: minor forfeat, major for a breaking change, patch otherwise. The bump goes in a final commit whose subject is the bare version.main, opening withFixes openscan-explorer/explorer#<n>(orPart of).CLAUDE.mdhas both rules in full;CONTRIBUTING.mdgets the version-bump rule. No hook enforces either one.Verification
pnpm build,pnpm testandpnpm lintpass at1.3.2.prettier --checkpasses onCLAUDE.mdandCONTRIBUTING.md.pnpm view @openscan/hardhat-plugin versionreturns1.3.1, so1.3.2is free.packages/plugin/package.json.example-projectlinks the plugin throughworkspace:*, so the lockfile doesn't change.