Skip to content

Fix Sleeping Bug #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadrasabouri merged 2 commits into from
Aug 29, 2026
+8 −3
Merged

Fix Sleeping Bug #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f561214
fix : update _attempt_with_retries function
sepandhaghighi Aug 24, 2026
ee88052
doc : update CHANGELOG.md
sepandhaghighi Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- CLI modified
- Dependencies structure modified
- Test system modified
- `_attempt_with_retries` function modified
## [0.8] - 2026-02-05
### Added
- Support [wtfismyip.com](https://wtfismyip.com/json) IPv6 API
Expand Down
10 changes: 7 additions & 3 deletions ipspot/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,14 @@ def _attempt_with_retries(
next_delay = retry_delay
for attempt in range(max_retries + 1):
result = func(**kwargs)

if result["status"]:
break
time.sleep(next_delay)
next_delay *= backoff_factor
return result

if attempt < max_retries:
time.sleep(next_delay)
next_delay *= backoff_factor

Comment on lines 92 to +101

@sadrasabouri sadrasabouri Aug 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a correct fix. I have a separate question:
The result = func(**kwargs) repeats max_retries + 1 times; am I right?
For attempt=0 to attempt=max_retries.

@sepandhaghighi sepandhaghighi Aug 28, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Because it's max_retries, not max_attempts.

total attempts = first attempt + max_retries

@sadrasabouri sadrasabouri Aug 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense now

return result


Expand Down
Loading