Skip to content

ROSAENG-62370: alerting: add SilenceReconcileErrors for hyperfleet silence reconciler - #786

Open
MitaliBhalla wants to merge 1 commit into
openshift-online:mainfrom
MitaliBhalla:feat/silence-reconcile-errors-alert
Open

MitaliBhalla wants to merge 1 commit into
openshift-online:mainfrom
MitaliBhalla:feat/silence-reconcile-errors-alert

Conversation

@MitaliBhalla

@MitaliBhalla MitaliBhalla commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Add SilenceReconcileErrors PrometheusRule for the hyperfleet-operator cluster-silence reconciler.

Fires when hyperfleet_silence_reconcile_errors_total increases over 15m — companion to openshift-online/rosa-hyperfleet-api#380.

Test plan

  • promtool check rules / alerting-rules CI passes after merge
  • Metric visible once hyperfleet-operator ServiceMonitor scrapes /metrics

Made with Cursor

Summary by CodeRabbit

  • New Features
    • Added monitoring for silence reconciliation errors.
    • A warning alert now triggers when reconciliation errors increase over a sustained period, helping teams identify alerting issues promptly.

Page when hyperfleet_silence_reconcile_errors_total increases, indicating
the cluster-silence reconciler cannot reach Alertmanager.

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 3, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

@MitaliBhalla: This pull request references ROSAENG-62370 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

Add SilenceReconcileErrors PrometheusRule for the hyperfleet-operator cluster-silence reconciler.

Fires when hyperfleet_silence_reconcile_errors_total increases over 15m — companion to openshift-online/rosa-hyperfleet-api#380.

Test plan

  • promtool check rules / alerting-rules CI passes after merge
  • Metric visible once hyperfleet-operator ServiceMonitor scrapes /metrics

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign theautoroboto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 13099cfc-6062-4004-82f4-edd8ef968504

📥 Commits

Reviewing files that changed from the base of the PR and between a67018a and 694a06a.

📒 Files selected for processing (1)
  • argocd/config/regional-cluster/alerting-rules/templates/hcp-silence-reconciler.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

A new PrometheusRule manifest defines the SilenceReconcileErrors warning alert for increases in silence reconciliation errors. It includes annotations, Helm and operator labels, and an ArgoCD dry-run sync option.

Changes

Alerting rule

Layer / File(s) Summary
Silence reconciliation PrometheusRule
argocd/config/regional-cluster/alerting-rules/templates/hcp-silence-reconciler.yaml
Adds the SilenceReconcileErrors alert for hyperfleet_silence_reconcile_errors_total, evaluated over 15 minutes and sustained for 5 minutes. The manifest includes alert annotations, labels, and SkipDryRunOnMissingResource=true.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 694a0

This change adds a warning alert for silence reconciliation errors. The alert rule is ready to merge with no identified current-head risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the alerting change and names the specific SilenceReconcileErrors alert for the hyperfleet silence reconciler.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants