Skip to content

ROSAENG-64876: Add consolidated weekly security report procedure - #798

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift-online:mainfrom
jonseidman:adversary-scan-chai-bot
Sep 15, 2026
Merged

openshift-merge-bot[bot] merged 2 commits into
openshift-online:mainfrom
jonseidman:adversary-scan-chai-bot

Conversation

@jonseidman

Copy link
Copy Markdown

Summary

Replaces the per-repo weekly Adversary scan notification with one consolidated report across the whole rosa-hyperfleet* family:

  • Live repo discovery (gh search repos) — no hardcoded repo list, catches repos added/removed since the last run.
  • A parallel Groundwork scan per discovered repo — one RWS pod + rws_goal_task each, all dispatched in the same turn so the whole family completes within the scheduler's 4-hour background-work ceiling.
  • Explicit multi-turn state tracking: the task gets woken up as each repo's scan completes and must confirm all repos have reported before ever calling send_response — never posts a partial report.
  • A single consolidated Slack report combining:
    • Executive summary for the three highest-criticality repos (rosa-hyperfleet, -api, -kube-applier), each with one cherry-picked, service-risk-framed finding
    • Top 5-10 CRITICAL/HIGH findings aggregated across the whole family (not per-repo)
    • A per-repo severity table with 🔴/🟡/🟢 status
    • Full per-repo results, alphabetically labeled

Companion change

Wired up by openshift-eng/ship-help-bot#649, which adds this file's %include() as the new rosa_hyperfleet_weekly_security_report scheduled task and switches the 6 individual per-repo scan tasks to manual-trigger-only.

Test plan

  • Merge alongside/after openshift-eng/ship-help-bot#649
  • Manually trigger the new scheduled task and confirm all current rosa-hyperfleet* repos get scanned in parallel, the task waits correctly across multiple completion wake-ups, and the final report matches the structure above

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 65f1f12a-8334-488c-b92a-2b3994bc7ed4


Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 10, 2026
@openshift-ci

openshift-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Hi @jonseidman. Thanks for your PR.

I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@psav

psav commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 11, 2026
@psav psav changed the title Add consolidated weekly security report procedure NO-JIRA: Add consolidated weekly security report procedure Sep 11, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 11, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Collaborator

@jonseidman: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

Replaces the per-repo weekly Adversary scan notification with one consolidated report across the whole rosa-hyperfleet* family:

  • Live repo discovery (gh search repos) — no hardcoded repo list, catches repos added/removed since the last run.
  • A parallel Groundwork scan per discovered repo — one RWS pod + rws_goal_task each, all dispatched in the same turn so the whole family completes within the scheduler's 4-hour background-work ceiling.
  • Explicit multi-turn state tracking: the task gets woken up as each repo's scan completes and must confirm all repos have reported before ever calling send_response — never posts a partial report.
  • A single consolidated Slack report combining:
  • Executive summary for the three highest-criticality repos (rosa-hyperfleet, -api, -kube-applier), each with one cherry-picked, service-risk-framed finding
  • Top 5-10 CRITICAL/HIGH findings aggregated across the whole family (not per-repo)
  • A per-repo severity table with 🔴/🟡/🟢 status
  • Full per-repo results, alphabetically labeled

Companion change

Wired up by openshift-eng/ship-help-bot#649, which adds this file's %include() as the new rosa_hyperfleet_weekly_security_report scheduled task and switches the 6 individual per-repo scan tasks to manual-trigger-only.

Test plan

  • Merge alongside/after openshift-eng/ship-help-bot#649
  • Manually trigger the new scheduled task and confirm all current rosa-hyperfleet* repos get scanned in parallel, the task waits correctly across multiple completion wake-ups, and the final report matches the structure above

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jonseidman

Copy link
Copy Markdown
Author

This is associated with Jira https://redhat.atlassian.net/browse/ROSAENG-64876 - will update title

@jonseidman jonseidman changed the title NO-JIRA: Add consolidated weekly security report procedure ROSAENG-64876: Add consolidated weekly security report procedure Sep 11, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

@jonseidman: This pull request references ROSAENG-64876 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

Replaces the per-repo weekly Adversary scan notification with one consolidated report across the whole rosa-hyperfleet* family:

  • Live repo discovery (gh search repos) — no hardcoded repo list, catches repos added/removed since the last run.
  • A parallel Groundwork scan per discovered repo — one RWS pod + rws_goal_task each, all dispatched in the same turn so the whole family completes within the scheduler's 4-hour background-work ceiling.
  • Explicit multi-turn state tracking: the task gets woken up as each repo's scan completes and must confirm all repos have reported before ever calling send_response — never posts a partial report.
  • A single consolidated Slack report combining:
  • Executive summary for the three highest-criticality repos (rosa-hyperfleet, -api, -kube-applier), each with one cherry-picked, service-risk-framed finding
  • Top 5-10 CRITICAL/HIGH findings aggregated across the whole family (not per-repo)
  • A per-repo severity table with 🔴/🟡/🟢 status
  • Full per-repo results, alphabetically labeled

Companion change

Wired up by openshift-eng/ship-help-bot#649, which adds this file's %include() as the new rosa_hyperfleet_weekly_security_report scheduled task and switches the 6 individual per-repo scan tasks to manual-trigger-only.

Test plan

  • Merge alongside/after openshift-eng/ship-help-bot#649
  • Manually trigger the new scheduled task and confirm all current rosa-hyperfleet* repos get scanned in parallel, the task waits correctly across multiple completion wake-ups, and the final report matches the structure above

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@@ -0,0 +1,165 @@
# Scheduled report: ROSA HyperFleet family weekly security report

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonseidman shall we remove the other adversary .md then in favor of this one? :) Otherwise it's just gonna lay around.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@typeid this PR is paired with openshift-eng/ship-help-bot/pull/649, which added the scheduled single/consolidated weekly scan and changed the individual per-repo scans to manual: https://github.com/openshift-eng/ship-help-bot/blob/bc89aa17263914ddf0abefbaea5a518f3e594309/config/groups/rosa/personas/rosa_hyperfleet.yaml#L136

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@typeid I'll modify .chai-bot/rosa_hyperfleet_adversary_scan.md to clearly clarify that .md is for the manual scans, and the scheduled weekly scan is configured in .chai-bot/rosa_hyperfleet_weekly_security_report.md.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This PR updated with the manual-scan wording clarification
  • ship-help-bot PR #693 - moved the individual repo scans out of the /scheduled/ folder to /rosa_hyperfleet/ to clean up the changes

Jon Seidman and others added 2 commits September 14, 2026 12:43
Replaces the per-repo weekly Adversary scan notification with one
consolidated report across the whole rosa-hyperfleet* family: live
repo discovery, a parallel Groundwork scan per repo (one RWS pod +
rws_goal_task each), and a single Slack report combining an executive
summary for the highest-criticality repos, aggregated top
critical/high findings, a per-repo severity table, and full per-repo
results.

Companion change in ship-help-bot (openshift-eng/ship-help-bot#649)
wires this up as the new rosa_hyperfleet_weekly_security_report
scheduled task and switches the 6 individual per-repo scan tasks to
manual-trigger-only.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Retitles and reframes this file to make clear it's for on-demand,
single-repo scans only (the scheduled task referencing it has
cron: "manual") -- and points to
.chai-bot/rosa_hyperfleet_weekly_security_report.md as the file the
actual cron-scheduled weekly scan runs. Addresses team confusion
about which file governs the automated weekly report vs. manual
single-repo checks.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@jonseidman
jonseidman force-pushed the adversary-scan-chai-bot branch from a77ceb9 to c67e4b4 Compare September 14, 2026 16:44
@typeid

typeid commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2026
@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: typeid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2026
@jonseidman

Copy link
Copy Markdown
Author

/retest

@openshift-merge-bot
openshift-merge-bot Bot merged commit 75d0d11 into openshift-online:main Sep 15, 2026
8 checks passed
@jonseidman
jonseidman deleted the adversary-scan-chai-bot branch September 15, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants