ROSAENG-64876: Add consolidated weekly security report procedure - #798
openshift-merge-bot[bot] merged 2 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: Comment |
|
Hi @jonseidman. Thanks for your PR. I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
@jonseidman: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
This is associated with Jira https://redhat.atlassian.net/browse/ROSAENG-64876 - will update title |
|
@jonseidman: This pull request references ROSAENG-64876 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -0,0 +1,165 @@ | |||
| # Scheduled report: ROSA HyperFleet family weekly security report | |||
There was a problem hiding this comment.
@jonseidman shall we remove the other adversary .md then in favor of this one? :) Otherwise it's just gonna lay around.
There was a problem hiding this comment.
@typeid this PR is paired with openshift-eng/ship-help-bot/pull/649, which added the scheduled single/consolidated weekly scan and changed the individual per-repo scans to manual: https://github.com/openshift-eng/ship-help-bot/blob/bc89aa17263914ddf0abefbaea5a518f3e594309/config/groups/rosa/personas/rosa_hyperfleet.yaml#L136
There was a problem hiding this comment.
@typeid I'll modify .chai-bot/rosa_hyperfleet_adversary_scan.md to clearly clarify that .md is for the manual scans, and the scheduled weekly scan is configured in .chai-bot/rosa_hyperfleet_weekly_security_report.md.
There was a problem hiding this comment.
- This PR updated with the manual-scan wording clarification
- ship-help-bot PR #693 - moved the individual repo scans out of the
/scheduled/folder to/rosa_hyperfleet/to clean up the changes
Replaces the per-repo weekly Adversary scan notification with one consolidated report across the whole rosa-hyperfleet* family: live repo discovery, a parallel Groundwork scan per repo (one RWS pod + rws_goal_task each), and a single Slack report combining an executive summary for the highest-criticality repos, aggregated top critical/high findings, a per-repo severity table, and full per-repo results. Companion change in ship-help-bot (openshift-eng/ship-help-bot#649) wires this up as the new rosa_hyperfleet_weekly_security_report scheduled task and switches the 6 individual per-repo scan tasks to manual-trigger-only. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Retitles and reframes this file to make clear it's for on-demand, single-repo scans only (the scheduled task referencing it has cron: "manual") -- and points to .chai-bot/rosa_hyperfleet_weekly_security_report.md as the file the actual cron-scheduled weekly scan runs. Addresses team confusion about which file governs the automated weekly report vs. manual single-repo checks. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
a77ceb9 to
c67e4b4
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: typeid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
75d0d11
into
openshift-online:main
Summary
Replaces the per-repo weekly Adversary scan notification with one consolidated report across the whole
rosa-hyperfleet*family:gh search repos) — no hardcoded repo list, catches repos added/removed since the last run.rws_goal_taskeach, all dispatched in the same turn so the whole family completes within the scheduler's 4-hour background-work ceiling.send_response— never posts a partial report.rosa-hyperfleet,-api,-kube-applier), each with one cherry-picked, service-risk-framed findingCompanion change
Wired up by openshift-eng/ship-help-bot#649, which adds this file's
%include()as the newrosa_hyperfleet_weekly_security_reportscheduled task and switches the 6 individual per-repo scan tasks to manual-trigger-only.Test plan
rosa-hyperfleet*repos get scanned in parallel, the task waits correctly across multiple completion wake-ups, and the final report matches the structure above