Skip to content

ROSAENG-66745: update: Add new ROSA_LABEL_FILTER and other environment variable with associated changes - #799

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-online:mainfrom
elveeram:addnewMake
Sep 16, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift-online:mainfrom
elveeram:addnewMake

Conversation

@elveeram

@elveeram elveeram commented Sep 10, 2026

Copy link
Copy Markdown
Contributor
  1. ci/e2e-tests.sh
    - Added ROSA CLI test integration with variables: ROSA_REPO_URL, ROSA_REPO_BRANCH,ROSA_TEST_PROFILE, ROSA_LABEL_FILTER
    - Added export GOTOOLCHAIN=auto for ROSA CLI tests
    - Wrapped Platform API, ZOA, ROSA CLI, and Monitoring tests with skip conditionals
    - Updated final results reporting to include rosa-cli
  2. scripts/dev/ephemeral-env.sh
    - Added environment variable passthrough for ROSA CLI configuration:
    • ROSA_REPO_URL, ROSA_REPO_BRANCH, ROSA_TEST_PROFILE , ROSA_LABEL_FILTER
      - Added skip flag passthrough:
    • E2E_SKIP_PLATFORM_API, E2E_SKIP_HCP, E2E_SKIP_MONITORING, E2E_SKIP_ROSA_CLI, E2E_SKIP_ZOA

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: a2ceb2d5-a009-45ad-a61c-25429e175195


Comment @coderabbitai help to get the list of available commands.

@cdoan1 cdoan1 changed the title ROSAENG-66745 | update: Remove ROSACTL tests replaced with ROSACLI ROSAENG-66745: update: Remove ROSACTL tests replaced with ROSACLI Sep 11, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 11, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

@elveeram: This pull request references ROSAENG-66745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Remove ROSACTL tests replaced with ROSACLI

  1. ci/e2e-tests.sh (+58 lines, -57 lines)
  • Added ROSA CLI test integration with variables: ROSA_REPO_URL, ROSA_REPO_BRANCH, ROSA_CLI_FOCUS, ROSA_TEST_PROFILE
  • Removed test_hcp_creation() function and HCP Creation Tests section
  • Added rosa_cli_rc exit code tracking
  • Added export GOTOOLCHAIN=auto for ROSA CLI tests
  • Wrapped Platform API, ZOA, ROSA CLI, and Monitoring tests with skip conditionals
  • Updated final results reporting to include rosa-cli
  1. scripts/dev/ephemeral-env.sh (+9 lines)
  • Added environment variable passthrough for ROSA CLI configuration:
    • ROSA_REPO_URL, ROSA_REPO_BRANCH, ROSA_CLI_FOCUS, ROSA_TEST_PROFILE
  • Added skip flag passthrough:
    • E2E_SKIP_PLATFORM_API, E2E_SKIP_HCP, E2E_SKIP_MONITORING, E2E_SKIP_ROSA_CLI, E2E_SKIP_ZOA

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@elveeram elveeram changed the title ROSAENG-66745: update: Remove ROSACTL tests replaced with ROSACLI ROSAENG-66745: update: Add new ROSA_LABEL_FILTER and other environment variable with associated changes Sep 11, 2026
@cdoan1

cdoan1 commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

/retest

@cdoan1

cdoan1 commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

/test on-demand-e2e

@elveeram

Copy link
Copy Markdown
Contributor Author

/test on-demand-e2e

Updated per comments. Add back missing E2E_SKIP_HCP initialization.
@elveeram

Copy link
Copy Markdown
Contributor Author

/test on-demand-e2e

@cdoan1

cdoan1 commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2026
@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdoan1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit e61ba00 into openshift-online:main Sep 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants