LOG-9751: fix(filter:drop): add validation to restrict inclusion of s…

[jcantrill]

…ingle quote to condition

Backport of #3420 (LOG-9704) to release-6.5.

Prevents config injection through drop filter matches/notMatches by rejecting single quotes, newlines, and carriage returns at three layers: CRD schema pattern validation, operator filter validation, and VRL generation. Also fixes an existing bug where notMatches was validated against the Matches value.

Description

https://redhat.atlassian.net/browse/LOG-9751

cc @vparfonov @Clee2691

[openshift-ci-robot]

@jcantrill: No Jira issue with key LOG-9751 exists in the tracker at https://redhat.atlassian.net.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

…ingle quote to condition

Backport of #3420 (LOG-9704) to release-6.5.

Prevents config injection through drop filter matches/notMatches by rejecting single quotes, newlines, and carriage returns at three layers: CRD schema pattern validation, operator filter validation, and VRL generation. Also fixes an existing bug where notMatches was validated against the Matches value.

Description

https://redhat.atlassian.net/browse/LOG-9751

cc @vparfonov @Clee2691

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7b8e14b7-edc4-45ac-9760-625753a0b4dd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jcantrill]

/retest

[jcantrill]

/retest

[jcantrill]

/test functional-target

[jcantrill]

/test e2e-target

[jcantrill]

/retest

[openshift-ci]

@jcantrill: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-target	c9ae996	link	true	/test e2e-target

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.