Skip to content

fix(cve) bumb go-grpc to 1.83.2 to fix CVE-2026-84445 - #3469

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
vparfonov:log10161_master
Sep 23, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
vparfonov:log10161_master

Conversation

@vparfonov

@vparfonov vparfonov commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Description

Port-forward: #3468

/cc @Clee2691
/assign @jcantrill

Links

  • Depending on PR(s):
  • GitHub issue:
  • JIRA:
  • Enhancement proposal:

Summary by CodeRabbit

  • Chores
    • Updated the application’s Go runtime and supporting libraries to newer versions.
    • Refreshed networking, synchronization, system, telemetry, configuration, and RPC components for compatibility and maintenance.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/cluster-logging-operator/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1e92f15f-d09c-4547-80ad-6296a643a92f

📥 Commits

Reviewing files that changed from the base of the PR and between dde56c0 and 842f75a.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The module now targets Go 1.26.0. Direct dependencies and several indirect dependencies were upgraded in go.mod. No exported or public entity declarations changed.

Changes

Go module updates

Layer / File(s) Summary
Module toolchain and dependency versions
go.mod
The Go version changed to 1.26.0. Direct golang.org/x dependencies and indirect CEL, HTTPSnoop, OpenTelemetry, YAML, Genproto, gRPC, and related modules were upgraded.

Priority: ⬆️ High

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: jcantrill

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes reviewer and approver assignments and references the related port-forward pull request. It does not explain the CVE, the go-grpc upgrade, the rationale, or the implementation … Add a clear summary stating that go-grpc is upgraded to version 1.83.2 to address CVE-2026-84445. Explain the rationale and relevant implementation impact. Keep the reviewer, approver, and related PR references.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary change: upgrading go-grpc to version 1.83.2 to address CVE-2026-84445. The typo “bumb” should be corrected to “bump,” but it does not prevent understanding.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes reviewer and approver assignments and references the related port-forward pull request. It does not explain the CVE, the go-grpc upgrade, the rationale, or the implementation scope required by the mandatory description section.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@vparfonov

Copy link
Copy Markdown
Contributor Author

/test e2e-using-bundle

@jcantrill

Copy link
Copy Markdown
Contributor

blocked by #3458 which include minio fix

@jcantrill

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2026
@jcantrill

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2026
@jcantrill

Copy link
Copy Markdown
Contributor

/retest

@jcantrill

Copy link
Copy Markdown
Contributor

/label verified

@openshift-ci openshift-ci Bot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 22, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 928795a and 2 for PR HEAD 842f75a in total

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 517d315 and 1 for PR HEAD 842f75a in total

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2026
Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@openshift-ci openshift-ci Bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 23, 2026
@vparfonov

Copy link
Copy Markdown
Contributor Author

/retest-required

@jcantrill

Copy link
Copy Markdown
Contributor

/test e2e-using-bundle

@jcantrill

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2026
@openshift-ci

openshift-ci Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

@vparfonov: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit f5cc121 into openshift:master Sep 23, 2026
9 checks passed
@vparfonov
vparfonov deleted the log10161_master branch September 24, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release/6.7 verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants