Skip to content

fix(test): use Vector devel image for HTTP TLS e2e test - NO JIRA - #3473

Closed
Clee2691 wants to merge 1 commit into
openshift:masterfrom
Clee2691:fix-http-tls-e2e
Closed

Clee2691 wants to merge 1 commit into
openshift:masterfrom
Clee2691:fix-http-tls-e2e

Conversation

@Clee2691

@Clee2691 Clee2691 commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR fixes the HTTP TLS e2e test by using the vector devel image instead.

Should unblock the failing master e2e tests

/cc @vparfonov
/assign @jcantrill

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the TLS-enabled HTTP receiver deployment to use the appropriate receiver container image.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/cluster-logging-operator/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f7ae4443-6081-4204-a76a-e40c19959dad

📥 Commits

Reviewing files that changed from the base of the PR and between dde56c0 and fff9287.

📒 Files selected for processing (1)
  • test/framework/e2e/http_vector.go

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

Changes

TLS receiver image selection

Layer / File(s) Summary
Update TLS receiver image constant
test/framework/e2e/http_vector.go
The TLS receiver deployment now uses constants.VectorReceiverName for its container image.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: jcantrill

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states that the HTTP TLS end-to-end test should use the Vector development image. It matches the main change.
Description check ✅ Passed The description explains the change and its purpose, and it includes both a reviewer assignment and an approver assignment. The optional Links section is omitted.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@qodo-for-rh-openshift

Copy link
Copy Markdown

PR Summary by Qodo

Use Vector devel receiver image for HTTP TLS e2e tests

🐞 Bug fix 🧪 Tests 🕐 Less than 5 minutes

Grey Divider

AI Description

• Selects the dedicated Vector receiver image for TLS-enabled HTTP receiver deployments.
• Aligns TLS and non-TLS receiver setup, unblocking failing end-to-end tests.
High-Level Assessment

The current approach is optimal because it reuses the established VectorReceiverName component mapping and makes the TLS helper consistent with the non-TLS receiver helper. Directly reading the receiver image environment variable would bypass centralized image resolution without providing a benefit.

Files changed (1) +1 / -1

Bug fix (1) +1 / -1
http_vector.goUse receiver-specific Vector image for TLS tests +1/-1

Use receiver-specific Vector image for TLS tests

• Changes the TLS-enabled HTTP receiver deployment to resolve the dedicated Vector receiver image instead of the standard Vector component image. This ensures the test container includes the development tooling expected by the end-to-end setup.

test/framework/e2e/http_vector.go

@qodo-for-rh-openshift

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@vparfonov

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2026
@jcantrill

Copy link
Copy Markdown
Contributor

/approve
/label verified

@openshift-ci openshift-ci Bot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 21, 2026
@openshift-ci

openshift-ci Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Clee2691, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2026
@Clee2691

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD dde56c0 and 2 for PR HEAD fff9287 in total

@Clee2691

Copy link
Copy Markdown
Contributor Author

/retest

@vparfonov

Copy link
Copy Markdown
Contributor

/test e2e-using-bundle

1 similar comment
@Clee2691

Copy link
Copy Markdown
Contributor Author

/test e2e-using-bundle

@qodo-for-rh-openshift

Copy link
Copy Markdown

Important

The /test command by Qodo was deprecated on the 1st of September 2026 and is no longer available. We recommend switching to the latest Qodo review capabilities. Learn more

@Clee2691

Copy link
Copy Markdown
Contributor Author

closed because #3458 includes the fix

@Clee2691 Clee2691 closed this Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release/6.7 verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants