Skip to content

Switch minio image references to own mirror - #3482

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
xperimental:minio-mirror
Sep 25, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
xperimental:minio-mirror

Conversation

@xperimental

@xperimental xperimental commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Description

The quay mirror of minio went away as well. This is a temporary fix to get tests working again, a replacement for Minio needs to be selected.

/cc @jcantrill

Summary by CodeRabbit

  • Chores
    • Updated the MinIO image used in end-to-end and functional tests to a mirrored, pinned release.

@openshift-ci
openshift-ci Bot requested a review from jcantrill September 25, 2026 11:42
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/cluster-logging-operator/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 01bef4e3-dc3f-4d3f-a766-306483a07c5e

📥 Commits

Reviewing files that changed from the base of the PR and between 903d6a6 and 1257a6f.

📒 Files selected for processing (2)
  • test/framework/e2e/lokistack.go
  • test/framework/functional/output_s3.go

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The E2E and functional test frameworks now use quay.io/openshift-logging/minio-mirror:RELEASE.2025-09-07T16-13-09Z for MinIO.

Changes

MinIO test image references

Layer / File(s) Summary
Update MinIO test image references
test/framework/e2e/lokistack.go, test/framework/functional/output_s3.go
Both MinIO references now use the OpenShift Logging mirror image at release 2025-09-07T16-13-09Z.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: jcantrill

Merge Risk: ⚪ Minimal · up to 1257a

The mirrored MinIO image supports both test setups, with no concrete test-workflow issue identified. The change is ready for normal checks and merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the reason for the change and identifies it as a temporary fix. It includes a reviewer assignment, but it omits the mandatory approver assignment and does not include the temp… Add /assign with at least one approver from the top-level OWNERS file. Add the Links section and complete any applicable dependency, GitHub issue, JIRA, or enhancement proposal entries, or state that none apply.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: switching MinIO image references to the project’s own mirror.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the reason for the change and identifies it as a temporary fix. It includes a reviewer assignment, but it omits the mandatory approver assignment and does not include the template’s Links section.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2026

@JoaoBraveCoding JoaoBraveCoding left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2026
@openshift-ci

openshift-ci Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoaoBraveCoding, xperimental

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcantrill

Copy link
Copy Markdown
Contributor

/label verified

@openshift-ci openshift-ci Bot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 25, 2026
@jcantrill

Copy link
Copy Markdown
Contributor

/cherrypick release-6.6

@openshift-cherrypick-robot

Copy link
Copy Markdown

@jcantrill: once the present PR merges, I will cherry-pick it on top of release-6.6 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-6.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

@xperimental: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 9c9032d into openshift:master Sep 25, 2026
9 checks passed
@openshift-cherrypick-robot

Copy link
Copy Markdown

@jcantrill: new pull request created: #3483

Details

In response to this:

/cherrypick release-6.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcantrill

Copy link
Copy Markdown
Contributor

/cherrypick release-6.5

@openshift-cherrypick-robot

Copy link
Copy Markdown

@jcantrill: #3482 failed to apply on top of branch "release-6.5":

Applying: Switch minio image references to own mirror
Using index info to reconstruct a base tree...
M	test/framework/functional/output_s3.go
Falling back to patching base and 3-way merge...
Auto-merging test/framework/functional/output_s3.go
CONFLICT (content): Merge conflict in test/framework/functional/output_s3.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Switch minio image references to own mirror

Details

In response to this:

/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release/6.7 verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants