Skip to content

feat(metrics): enable monitoring of the ns by default (LOG-10283) - #3484

Open
jcantrill wants to merge 1 commit into
openshift:masterfrom
jcantrill:log10283
Open

jcantrill wants to merge 1 commit into
openshift:masterfrom
jcantrill:log10283

Conversation

@jcantrill

@jcantrill jcantrill commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR:

  • enable metrics by default for the NS when installing from the console

Links

cc @vparfonov

Summary by CodeRabbit

  • New Features
    • Cluster Logging is now marked for default operator monitoring in the OpenShift console.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/cluster-logging-operator/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c2d9679f-17c3-48bd-8aa8-a29c684148b1

📥 Commits

Reviewing files that changed from the base of the PR and between 9c9032d and 1ff6f19.

📒 Files selected for processing (2)
  • bundle/manifests/cluster-logging.clusterserviceversion.yaml
  • config/manifests/bases/cluster-logging.clusterserviceversion.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The Cluster Logging ClusterServiceVersion manifests add the console.openshift.io/operator-monitoring-default: "true" annotation. The bundle manifest also updates its createdAt annotation.

Changes

Operator monitoring annotation

Layer / File(s) Summary
CSV annotation
config/manifests/bases/cluster-logging.clusterserviceversion.yaml, bundle/manifests/cluster-logging.clusterserviceversion.yaml
Both manifests add the operator monitoring default annotation. The bundle manifest updates createdAt to 2026-09-25T13:37:51Z.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Suggested reviewers: clee2691

Merge Risk: ⚪ Minimal · up to 1ff6f

The catalog installation path meets the conditions for Console to enable monitoring by default. No actionable merge risk remains from these changes.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the intent and includes the related JIRA issue, but it omits the mandatory approver assignment and does not provide the requested context or rationale. It also uses "cc @vparfon… Add the required /assign command with an approver from the top-level OWNERS file. Replace "cc @vparfonov" with the /cc command format. Expand the description with the issue context, rationale, and implementation overview.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: enabling namespace monitoring by default. It is concise and includes the related issue identifier.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description states the intent and includes the related JIRA issue, but it omits the mandatory approver assignment and does not provide the requested context or rationale. It also uses "cc @vparfonov" instead of the required /cc command format.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2026
@openshift-ci

openshift-ci Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. release/6.7

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant