[redhat-chai-bot]

What this PR does / why we need it:

Reverts #10106 on release-4.22.

Restore the headless etcd-client Service manifest and all five generated service fixtures, including their desired-state hashes. Remove the peer-certificate comments and unit tests introduced by #10106. Certificate-generation executable logic is unchanged. Preserve subsequent unrelated release-4.22 changes.

Which issue(s) this PR fixes:

None; this is a NO-JIRA revert of #10106.

Special notes for your reviewer:

This is the exact inverse of merge commit 61f1748 relative to its first parent. No Service migration or replacement logic is added. Existing allocated-IP-to-headless transitions are not validated by the focused tests.

Local checks passed on the unchanged revert with upstream Go1.26.0: make lint-fix, make verify, make test NUM_CORES=4, make build, and the complete make pre-commit NUM_CORES=4. The final aggregate run exited 0 in 26m27s, including binary/test compilation, generation, verification and the full race-enabled unit suite. Final generation/clean-diff, whitespace and exact-inverse checks passed. This does not claim execution in the exact Red Hat CI image.

An earlier aggregate run failed two support/konnectivityproxy tests (proxy read unexpected EOF; canceled-context resolution returned nil), and a bounded retry timed out. Those historical results remain recorded. The latest complete aggregate run passed, including that package, without source changes, test skips, weakened flags or proxy/DNS setting changes. The earlier failures' cause is not established.

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

---

AI-generated. Review for accuracy.

@devguyio requested from Slack

[openshift-merge-bot]

Pipeline controller notification

This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration.

Use /test ? to list jobs and /pipeline help for commands.

[openshift-ci-robot]

@redhat-chai-bot: This pull request explicitly references no jira issue.

Details

In response to this:

What this PR does / why we need it:

Reverts #10106 on release-4.22.

Restore the headless etcd-client Service manifest and all five generated service fixtures, including their desired-state hashes. Remove the peer-certificate comments and unit tests introduced by #10106. Certificate-generation executable logic is unchanged. Preserve subsequent unrelated release-4.22 changes.

Which issue(s) this PR fixes:

None; this is a NO-JIRA revert of #10106.

Special notes for your reviewer:

This is the exact inverse of merge commit 61f1748 relative to its first parent. No Service migration or replacement logic is added. Existing allocated-IP-to-headless transitions are not validated by the focused tests.

Local checks passed on the unchanged revert with upstream Go1.26.0: make lint-fix, make verify, make test NUM_CORES=4, make build, and the complete make pre-commit NUM_CORES=4. The final aggregate run exited 0 in 26m27s, including binary/test compilation, generation, verification and the full race-enabled unit suite. Final generation/clean-diff, whitespace and exact-inverse checks passed. This does not claim execution in the exact Red Hat CI image.

An earlier aggregate run failed two support/konnectivityproxy tests (proxy read unexpected EOF; canceled-context resolution returned nil), and a bounded retry timed out. Those historical results remain recorded. The latest complete aggregate run passed, including that package, without source changes, test skips, weakened flags or proxy/DNS setting changes. The earlier failures' cause is not established.

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

---

AI-generated. Review for accuracy.

@devguyio requested from Slack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: openshift/hypershift
• Branch: release-4.22
• File: .coderabbit.yaml
• Commit: fb62e00
• Layers: Repository YAML (base), Central YAML (inherited)
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 27f6dba1-21b6-45cd-9484-d7acd844ff0c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csrwng for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.42%. Comparing base (fb62e00) to head (5dd9ad6).

Additional details and impacted files

@@               Coverage Diff                @@
##           release-4.22   #10138      +/-   ##
================================================
- Coverage         37.43%   37.42%   -0.02%     
================================================
  Files               782      782              
  Lines             96235    96232       -3     
================================================
- Hits              36024    36012      -12     
- Misses            57331    57340       +9     
  Partials           2880     2880              

Files with missing lines	Coverage Δ
...perator/controllers/hostedcontrolplane/pki/etcd.go	0.00% <ø> (-44.45%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-ci]

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[redhat-chai-bot]

Coverage triage for the current head:

• codecov/project reports 37.42% (-0.02%) versus fb62e00; codecov/patch passes with “Coverage not affected.”
• The report identifies control-plane-operator/controllers/hostedcontrolplane/pki/etcd.go at 0%, down 44.45 percentage points.
• The exact revert deletes etcd_test.go, including TestReconcileEtcdPeerSecret. Its production etcd.go change removes comments only, not executable certificate-generation logic.
• The Unit Tests job passed, and its coverage upload completed successfully. This is a project-coverage failure, not a failed unit test or failed upload.

Retaining the certificate unit tests while reverting the Service change is a possible scoped adjustment, but would no longer be the exact inverse currently described. Awaiting that scope decision; no coverage configuration changes, overrides, or retests were made. Other CI remains pending.

---

AI-generated. Review for accuracy.