Skip to content

NO-JIRA: Update ipfailover/OWNERS to reflect current NID team#240

Open
Thealisyed wants to merge 1 commit into
openshift:masterfrom
Thealisyed:update-ipfailover-owners
Open

NO-JIRA: Update ipfailover/OWNERS to reflect current NID team#240
Thealisyed wants to merge 1 commit into
openshift:masterfrom
Thealisyed:update-ipfailover-owners

Conversation

@Thealisyed

@Thealisyed Thealisyed commented Jun 16, 2026

Copy link
Copy Markdown

Summary

  • Sync ipfailover/OWNERS approvers and reviewers with the current NID team roster
  • Matches the current cluster-ingress-operator OWNERS file
  • Move former team members to emeritus_approvers

Summary by CodeRabbit

Summary by CodeRabbit

  • Chores
    • Updated the project’s internal review and approval roster with a new ordered set of approvers and reviewers.
    • Replaced the prior approver/reviewer entries to match the updated roster.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 22b9aafa-6f19-4e88-85e3-b60190c02b03

📥 Commits

Reviewing files that changed from the base of the PR and between 8e0eb0c and 687335e.

📒 Files selected for processing (1)
  • ipfailover/OWNERS
✅ Files skipped from review due to trivial changes (1)
  • ipfailover/OWNERS

Walkthrough

The ipfailover/OWNERS file is updated to replace the approvers and reviewers lists with a consolidated ordered set of 12 users, removing prior users from active approval and review roles.

Changes

ipfailover OWNERS Roster Update

Layer / File(s) Summary
OWNERS approvers and reviewers consolidation
ipfailover/OWNERS
Both approvers and reviewers lists are replaced with the same ordered set of 12 users; previously active users are removed from both lists.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change—updating the ipfailover/OWNERS file to reflect the current NID team roster.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo tests exist in the repository. The PR updates the ipfailover/OWNERS file and adds standard Go unit tests (using testing package), not Ginkgo tests. The check is not applicable.
Test Structure And Quality ✅ Passed PR only modifies ipfailover/OWNERS configuration file; no Ginkgo test code is present or modified, making this check inapplicable.
Microshift Test Compatibility ✅ Passed This PR only updates the ipfailover/OWNERS configuration file with no Ginkgo e2e tests added, so the MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only modifies ipfailover/OWNERS, a configuration file that lists approvers and reviewers. No new Ginkgo e2e tests are added, so SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Change is to ipfailover/OWNERS, a purely administrative metadata file with no deployment manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed PR is a configuration-only change to ipfailover/OWNERS file with no code, binary, or test modifications. OTE Binary Stdout Contract check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only updates ipfailover/OWNERS configuration file; no Ginkgo e2e tests are added or modified, making this check not applicable.
No-Weak-Crypto ✅ Passed PR only modifies ipfailover/OWNERS (a user roster configuration file) with no cryptographic code changes, no weak crypto usage, and no custom crypto implementations.
Container-Privileges ✅ Passed The PR modifies only ipfailover/OWNERS file (team roster configuration), not any container/K8s manifests. The container-privileges check is not applicable to this configuration-only change.
No-Sensitive-Data-In-Logs ✅ Passed The PR modifies only ipfailover/OWNERS, containing public GitHub usernames and a component name. No passwords, tokens, API keys, PII, session IDs, hostnames, or customer data are present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from Miciah and knobunc June 16, 2026 16:56

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ipfailover/OWNERS`:
- Around line 1-33: The emeritus_approvers section in the OWNERS file is out of
sync with upstream. Update the emeritus_approvers field in the ipfailover/OWNERS
file to include only the three required entries (Ethany-RH, lmzuccarelli, ramr)
and remove the six extra entries (danwinship, dcbw, pecameron, pweil-,
rajatchopra, smarterclayton) that are currently present, ensuring the roster
achieves full parity with the upstream cluster-ingress-operator master branch.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3128a055-6b4a-4037-a76a-d361af73a882

📥 Commits

Reviewing files that changed from the base of the PR and between f5dba03 and 96936e3.

📒 Files selected for processing (1)
  • ipfailover/OWNERS

Comment thread ipfailover/OWNERS Outdated
@Thealisyed

Copy link
Copy Markdown
Author

ci/prow/e2e-aws - The HAProxy router should add replicas beyond the number of empty slots per backend. Being fixed in PR

ci/prow/e2e-metal-ipi-ovn-ipv6 - sysctl whitelists net.ipv4.ip_unprivileged_port_star

@Thealisyed Thealisyed changed the title Update ipfailover/OWNERS to reflect current NID team NO-JIRA: Update ipfailover/OWNERS to reflect current NID team Jun 17, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 17, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@Thealisyed: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

  • Sync ipfailover/OWNERS approvers and reviewers with the current NID team roster
  • Matches the current cluster-ingress-operator OWNERS file
  • Move former team members to emeritus_approvers

Summary by CodeRabbit

  • Chores
  • Updated internal code review and approval processes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Comment thread ipfailover/OWNERS Outdated
Comment thread ipfailover/OWNERS Outdated
Comment thread ipfailover/OWNERS Outdated
Comment thread ipfailover/OWNERS Outdated
Comment thread ipfailover/OWNERS Outdated
@candita

candita commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

/verify bypass

@candita

candita commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

I added this because we don't need QE on this PR.
/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 17, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@candita: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@candita

candita commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

/retest-required

@Thealisyed Thealisyed force-pushed the update-ipfailover-owners branch from 96936e3 to 8e0eb0c Compare June 18, 2026 08:56
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Jun 18, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@Thealisyed: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

  • Sync ipfailover/OWNERS approvers and reviewers with the current NID team roster
  • Matches the current cluster-ingress-operator OWNERS file
  • Move former team members to emeritus_approvers

Summary by CodeRabbit

Summary by CodeRabbit

  • Chores
  • Updated the project’s internal review and approval roster to reflect a new ordered set of approvers and reviewers.
  • Adjusted reviewer/approver lists to align with the updated roster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@candita

candita commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

/verified bypass
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 18, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@candita: The verified label has been added.

Details

In response to this:

/verified bypass
/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 18, 2026
@candita

candita commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

/hold

@Thealisyed please add @melvinjoseph86 to the list.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2026
Sync approvers and reviewers with the current NID team roster,
matching cluster-ingress-operator OWNERS.

Assisted with Claude
@Thealisyed Thealisyed force-pushed the update-ipfailover-owners branch from 8e0eb0c to 687335e Compare June 19, 2026 11:16
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Jun 19, 2026
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@Thealisyed: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

  • Sync ipfailover/OWNERS approvers and reviewers with the current NID team roster
  • Matches the current cluster-ingress-operator OWNERS file
  • Move former team members to emeritus_approvers

Summary by CodeRabbit

Summary by CodeRabbit

  • Chores
  • Updated the project’s internal review and approval roster with a new ordered set of approvers and reviewers.
  • Replaced the prior approver/reviewer entries to match the updated roster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@melvinjoseph86

Copy link
Copy Markdown

/verified bypass
/lgtm
/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2026
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 19, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@melvinjoseph86: The verified label has been added.

Details

In response to this:

/verified bypass
/lgtm
/unhold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2026
@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita, melvinjoseph86, Thealisyed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@melvinjoseph86

Copy link
Copy Markdown

/retest-required

1 similar comment
@melvinjoseph86

Copy link
Copy Markdown

/retest-required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1d29b6f and 2 for PR HEAD 687335e in total

@melvinjoseph86

Copy link
Copy Markdown

/retest-required

@openshift-ci

openshift-ci Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

@Thealisyed: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws 687335e link true /test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants