OU-1472: remove incidents feature from backend and tests

[PeterYurkovich]

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

Summary by CodeRabbit

• Updates
  • Reclassified the Incidents feature and related automated tests as Cluster Health Analyzer across feature options, documentation, and test filtering.
  • Updated test commands and tags while preserving existing scenarios and coverage.
• Maintenance
  • Removed the retired Incidents option from server declarations, command-line help, and feature-specific configuration.
  • Added token-related files to repository ignore rules.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@PeterYurkovich: This pull request references OU-1472 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [PeterYurkovich]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Walkthrough

The PR replaces the @incidents Cypress tag with @cluster-health-analyzer, updates related server declarations, scripts, documentation, and test suites, removes the old server feature constant, and ignores .tokensave/.

Changes

Incidents feature tag rename

Layer / File(s)	Summary
Server feature declarations and patch gates pkg/server/server.go, cmd/plugin-backend.go, pkg/server/plugin_handler.go	The exported Incidents feature value and CLI feature listing are removed. Plugin patch gates no longer use Incidents.
Cypress tag contract and selection web/cypress/support/test-tags.d.ts, web/package.json, web/cypress/README.md, .claude/commands/cypress/cypress-run.md	Cypress types, scripts, documentation, and command references use @cluster-health-analyzer.
Cypress suite metadata web/cypress/e2e/incidents/...	Incident E2E, performance, and regression suites replace @incidents with @cluster-health-analyzer. Test scenarios remain unchanged.

Repository ignore configuration

Layer / File(s)	Summary
Token save directory ignore .gitignore	The .tokensave/ directory is added to ignored paths.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: davidrajnoha, zhuje

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main changes: removing the incidents feature from the backend and its tests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR adds no Ginkgo test declarations or dynamic titles. Cypress describe/it title strings remain unchanged; the changes only retag suites and reformat one suite.
Test Structure And Quality	✅ Passed	The PR changes only Cypress TypeScript tags, docs, and backend feature wiring; no Ginkgo test files or Ginkgo constructs changed, so this check is not applicable.
Microshift Test Compatibility	✅ Passed	The diff adds no files or Ginkgo constructs; it only changes existing Cypress tests, documentation, and backend declarations, so this check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR adds no Ginkgo e2e tests. Changed Cypress specs only retag existing suites, and changed Go files are non-test backend files with no Ginkgo declarations.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR changes feature gating and Cypress tags only; the diff adds no deployment manifests, operators, controllers, or topology-related scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	PR Go changes only remove the incidents feature and alter patch conditions; no stdout writes were added, and logrus v1.9.3 defaults its logger output to os.Stderr.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The diff adds no Ginkgo e2e tests. It only retags existing Cypress TypeScript suites and changes production Go configuration, so this check is not applicable.
No-Weak-Crypto	✅ Passed	The PR diff only changes feature flags, Cypress tags, formatting, and .gitignore entries; it adds no weak crypto, custom crypto, or secret-comparison logic.
Container-Privileges	✅ Passed	The PR changes no container or Kubernetes manifest and adds no privilege settings; chart defaults retain runAsNonRoot:true and allowPrivilegeEscalation:false.
No-Sensitive-Data-In-Logs	✅ Passed	The PR diff adds no logging calls or sensitive values. Existing cy.log calls are unchanged; semantic changes only retag tests and remove the incidents feature.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch remove-incidents

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@cmd/plugin-backend.go`:
- Line 20: Update all Incidents feature references consistently: inspect the
feature definitions in server.go and replace features[Incidents] usages in
plugin_handler.go with the supported feature, or restore an Incidents
compatibility alias if that is the intended contract. Apply the same decision to
the frontend incidents field so backend and frontend feature names remain
aligned and the Go package compiles.

In `@web/cypress/README.md`:
- Line 231: Align the Cypress README tag taxonomy with the TestTags declaration:
move `@cluster-health-analyzer` from “Specific Feature Tags” to the high-level
category, or update the corresponding HighLevelComponentTag declaration in
test-tags.d.ts if the documented category is intended. Ensure both sources
classify the tag consistently.

In `@web/cypress/support/test-tags.d.ts`:
- Line 10: Remove the semicolon after the `@dashboards` member in the
HighLevelComponentTag union, retain `@cluster-health-analyzer` in that union, and
ensure only the final member has the terminating semicolon.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 88abae9f-72f0-4d3a-8bb4-003654af8898

📥 Commits

Reviewing files that changed from the base of the PR and between 4871cd7 and 7197ea4.

📒 Files selected for processing (19)

• .claude/commands/cypress/cypress-run.md
• .gitignore
• cmd/plugin-backend.go
• pkg/server/server.go
• web/cypress/README.md
• web/cypress/e2e/incidents/00.coo_incidents_e2e.cy.ts
• web/cypress/e2e/incidents/01.incidents.cy.ts
• web/cypress/e2e/incidents/02.incidents-mocking-example.cy.ts
• web/cypress/e2e/incidents/performance/01.performance_benchmark.cy.ts
• web/cypress/e2e/incidents/performance/02.performance_walkthrough.cy.ts
• web/cypress/e2e/incidents/regression/01.reg_filtering.cy.ts
• web/cypress/e2e/incidents/regression/02.reg_ui_charts_comprehensive.cy.ts
• web/cypress/e2e/incidents/regression/02.reg_ui_tooltip_boundary_times.cy.ts
• web/cypress/e2e/incidents/regression/03-04.reg_e2e_firing_alerts.cy.ts
• web/cypress/e2e/incidents/regression/03.reg_api_calls.cy.ts
• web/cypress/e2e/incidents/regression/04.reg_redux_effects.cy.ts
• web/cypress/e2e/incidents/regression/05.reg_stress_testing_ui.cy.ts
• web/cypress/support/test-tags.d.ts
• web/package.json

💤 Files with no reviewable changes (1)

• pkg/server/server.go

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pkg/server/plugin_handler.go`:
- Around line 45-47: Add or update unit tests for patchManifest to cover the
revised feature gates: verify monitoring-console-plugin.patch.json is enabled by
ClusterHealthAnalyzer or PersesDashboards or AcmAlerting,
acm-alerting.patch.json is enabled by AcmAlerting, and
cluster-health-analyzer.patch.json is enabled by ClusterHealthAnalyzer; also
verify each patch remains disabled when none of its controlling features is
configured.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d7ed8219-7a63-43dc-9beb-d8ff73c48654

📥 Commits

Reviewing files that changed from the base of the PR and between 7197ea4 and 34b6359.

📒 Files selected for processing (2)

• pkg/server/plugin_handler.go
• web/cypress/support/test-tags.d.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• web/cypress/support/test-tags.d.ts

[PeterYurkovich]

/retest ci/prow/images

[PeterYurkovich]

/test images

[PeterYurkovich]

CI has an issue with the login token being used. This is typically fixed by the prow team, going to not attempt any more runs until it is resolved

[PeterYurkovich]

Actually I thought about this more and this may need a conversion webhook on the operators side. This may be best to wait until we create the v1alpha2 or v1 of the CR to do. Will discuss more in the tech sync

[PeterYurkovich]

Actually actually we can just change the code [here] (https://github.com/rhobs/observability-operator/blob/261b08627f290eef6f5589a52a5c301d3a9be0e3/pkg/controllers/uiplugin/monitoring.go#L169) to pass in the other feature flag instead and its fine

[PeterYurkovich]

/retest

[PeterYurkovich]

/pipeline required

[openshift-merge-bot]

Scheduling required tests:
/test e2e-agnostic-cmo
/test e2e-management-api
/test e2e-monitoring

[openshift-ci]

@PeterYurkovich: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[PeterYurkovich]

/hold for branch

[openshift-ci]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.