OCPNETUI-114: Add network topology view by pcbailey · Pull Request #561 · openshift/networking-console-plugin

pcbailey · 2026-09-28T15:41:15Z

This PR adds the initial network configuration topology view.

Jira: https://redhat.atlassian.net/browse/OCPNETUI-114

Demo:

initial-topology-view--2026-10-23-11-38-37.mp4

openshift-merge-bot · 2026-09-28T15:41:17Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-09-28T15:41:19Z

@pcbailey: This pull request references OCPNETUI-114 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

This PR adds the initial network configuration topology view.

Jira: https://redhat.atlassian.net/browse/OCPNETUI-114

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-09-28T15:41:20Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

coderabbitai · 2026-09-28T15:41:23Z

Important

🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Central YAML; Path: .coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: af65c4c1-9b77-4547-86c6-29110081299f

_{Comment @coderabbitai help to get the list of available commands.}

Parthivk100 · 2026-10-23T14:19:04Z

/lgtm

openshift-merge-bot · 2026-10-23T14:20:00Z

Scheduling required tests:
/test e2e

Parthivk100 · 2026-10-23T15:39:36Z

/lgtm

openshift-merge-bot · 2026-10-23T15:40:17Z

Scheduling required tests:
/test e2e

pcbailey · 2026-10-26T16:52:11Z

/retest

Parthivk100 · 2026-10-26T17:28:52Z

/lgtm

openshift-merge-bot · 2026-10-26T17:29:25Z

Scheduling required tests:
/test e2e

openshift-merge-bot · 2026-10-26T19:16:44Z

/retest-required

Remaining retests: 0 against base HEAD 648a668 and 2 for PR HEAD b1ce4f9 in total

rszwajko · 2026-10-27T08:49:30Z

-  " See more details in: <3></3>.": " Ver más detalles en: <3></3>.",
-  "(all nodes): ": "(todos los nodos): ",
-  "{{count}} annotation_one": "{{count}} anotación",
+  " See more details in: <3></3>": " See more details in: <3></3>",


it seems that non-English translations got overridden. Please revert.

rszwajko · 2026-10-27T10:38:04Z

    "@patternfly/react-styles": "6.6.1",
    "@patternfly/react-table": "6.6.2",
    "@patternfly/react-tokens": "6.6.1",
+    "@patternfly/react-topology": "^6.6.0",


In order to match the versions used in the Console we need to pin the version here..
You can also run npm run shared-modules:sync -- release-5.1 which should automatically sync the correct versions.

rszwajko · 2026-10-27T10:48:19Z

+      return false;
+    }
+
+    if (isClusterUDN(udn)) {


to be fully accurate we need to check namespaceSelector

rszwajko · 2026-10-27T10:51:24Z

+ */
+export const podUsesUDN = (pod: IoK8sApiCoreV1Pod, udn: UDNResource): boolean => {
+  const udnNamespace = getNamespace(udn);
+  const nadCandidates = getUDNNADNameCandidates(udn);


is it safe to assume certain naming patterns as done in getUDNNADNameCandidates ?

rszwajko · 2026-10-27T10:52:19Z

+/**
+ * Check if a Pod uses a UDN or ClusterUDN
+ */
+export const podUsesUDN = (pod: IoK8sApiCoreV1Pod, udn: UDNResource): boolean => {


how do we handle primary UDN path? do we need similar logic as in vmUsesUDN()?

rszwajko · 2026-10-27T11:06:48Z

+    // For namespace-scoped primary UDNs, VM must be in the same namespace
+    if (udnNamespace && vmNamespace === udnNamespace) {
+      // Check if VM has a pod network (which would use the primary UDN)
+      const hasPodNetwork = networks.some((network) => Boolean(network.pod));


as per work-in-progress docs the use of autoattached pod network with UDN is discouraged but not impossible. At minimum we should test if the case is handled gracefully.

rszwajko · 2026-10-27T11:20:57Z

+export const vmHasSecondaryNetworks = (vm: V1VirtualMachine): boolean => {
+  // TODO Check logic
+  // const networks = getNetworks(vm);
+  // return networks.some((network) => network.multus?.networkName);


note that although exotic it's possible to have a multus network as the default pod network

rszwajko

Thank you for addressing the issue with translations. We can discuss other points in follow-ups.

openshift-merge-bot · 2026-10-28T12:06:08Z

Scheduling required tests:
/test e2e

openshift-ci · 2026-10-28T12:06:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, rszwajko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [pcbailey,rszwajko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rszwajko · 2026-10-28T12:57:23Z

/lgtm

openshift-merge-bot · 2026-10-28T12:58:00Z

Scheduling required tests:
/test e2e

openshift-ci · 2026-10-28T14:18:27Z

@pcbailey: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 28, 2026

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2026

openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 28, 2026

pcbailey force-pushed the topology/add-initial-topology-view branch from 1959456 to 6184f16 Compare October 14, 2026 12:47

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2026

pcbailey force-pushed the topology/add-initial-topology-view branch 2 times, most recently from 1afddf7 to fd4bea1 Compare October 21, 2026 11:33

pcbailey force-pushed the topology/add-initial-topology-view branch 2 times, most recently from 5b3061b to 94fc7ad Compare October 23, 2026 13:52

openshift-ci Bot assigned Parthivk100 Oct 23, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2026

pcbailey force-pushed the topology/add-initial-topology-view branch from 94fc7ad to 9cbefc2 Compare October 23, 2026 15:35

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2026

pcbailey marked this pull request as ready for review October 23, 2026 15:38

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2026

openshift-ci Bot requested review from Parthivk100 and rszwajko October 23, 2026 15:38

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2026

pcbailey force-pushed the topology/add-initial-topology-view branch from 9cbefc2 to abfb6d6 Compare October 23, 2026 15:43

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2026

pcbailey force-pushed the topology/add-initial-topology-view branch from abfb6d6 to b3da163 Compare October 26, 2026 00:22

pcbailey force-pushed the topology/add-initial-topology-view branch from b3da163 to a163c7d Compare October 26, 2026 00:31

pcbailey force-pushed the topology/add-initial-topology-view branch from a163c7d to b1ce4f9 Compare October 26, 2026 17:19

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2026

rszwajko requested changes Oct 27, 2026

View reviewed changes

openshift-ci Bot assigned rszwajko Oct 27, 2026

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2026

rszwajko reviewed Oct 27, 2026

View reviewed changes

pcbailey force-pushed the topology/add-initial-topology-view branch 2 times, most recently from a795b40 to 2f881b0 Compare October 28, 2026 12:01

rszwajko approved these changes Oct 28, 2026

View reviewed changes

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2026

Add network topology view

1434f71

pcbailey force-pushed the topology/add-initial-topology-view branch from 2f881b0 to 1434f71 Compare October 28, 2026 12:46

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2026

openshift-merge-bot Bot merged commit 8660a51 into openshift:main Oct 28, 2026
8 checks passed

Conversation

pcbailey commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-merge-bot Bot commented Sep 28, 2026

Uh oh!

openshift-ci-robot commented Sep 28, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Sep 28, 2026

Uh oh!

coderabbitai Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Parthivk100 commented Oct 23, 2026

Uh oh!

openshift-merge-bot Bot commented Oct 23, 2026

Uh oh!

Parthivk100 commented Oct 23, 2026

Uh oh!

openshift-merge-bot Bot commented Oct 23, 2026

Uh oh!

pcbailey commented Oct 26, 2026

Uh oh!

Parthivk100 commented Oct 26, 2026

Uh oh!

openshift-merge-bot Bot commented Oct 26, 2026

Uh oh!

openshift-merge-bot Bot commented Oct 26, 2026

Uh oh!

rszwajko Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

rszwajko Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

rszwajko Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

rszwajko Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

rszwajko Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

rszwajko Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

rszwajko Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

rszwajko left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-merge-bot Bot commented Oct 28, 2026

Uh oh!

openshift-ci Bot commented Oct 28, 2026

Uh oh!

rszwajko commented Oct 28, 2026

Uh oh!

openshift-merge-bot Bot commented Oct 28, 2026

Uh oh!

openshift-ci Bot commented Oct 28, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pcbailey commented Sep 28, 2026 •

edited

Loading

openshift-ci-robot commented Sep 28, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Sep 28, 2026 •

edited

Loading