OADP-8448: Added service accounts to 1.6

[NicholasYancey]

Why the changes were made

The CLI and VMDP download server pods on oadp-1.6 currently run with no ServiceAccount specified, which means they default to the namespace's default ServiceAccount. This fails Telco/CNF certification checks:

access-control-pod-service-account requires every pod to use a non-default ServiceAccount. This same fix was already backported directly to oadp-1.3 (#2310), oadp-1.4 (#2312), and oadp-1.5 (#2309), but was never in oadp-dev/oadp-1.6 as those branches only picked up readiness/liveness probes via #2306/#2307. This PR closes that gap for oadp-1.6, covering both the CLI and VMDP servers (unlike 1.3/1.4/1.5, oadp-1.6 has both controllers).

How to test the changes made

How to test the changes made

go test ./internal/controller/... -run 'CLIServer|VMDPServer' -v

Deploy the operator from this branch.
Check the ServiceAccounts exist:

oc get sa -n openshift-adp openshift-adp-cli-server openshift-adp-vmdp-server

Check the deployments use them:

oc get deploy -n openshift-adp openshift-adp-oadp-cli-server openshift-adp-oadp-vmdp-server \
  -o jsonpath='{.spec.template.spec.serviceAccountName}{"\n"}'

[openshift-ci-robot]

@NicholasYancey: This pull request references OADP-8448 which is a valid jira issue.

Details

In response to this:

Why the changes were made

The CLI and VMDP download server pods on oadp-1.6 currently run with no ServiceAccount specified, which means they default to the namespace's default ServiceAccount. This fails Telco/CNF certification checks:

access-control-pod-service-account requires every pod to use a non-default ServiceAccount. This same fix was already backported directly to oadp-1.3 (#2310), oadp-1.4 (#2312), and oadp-1.5 (#2309), but was never in oadp-dev/oadp-1.6 as those branches only picked up readiness/liveness probes via #2306/#2307. This PR closes that gap for oadp-1.6, covering both the CLI and VMDP servers (unlike 1.3/1.4/1.5, oadp-1.6 has both controllers).

How to test the changes made

How to test the changes made

go test ./internal/controller/... -run 'CLIServer|VMDPServer' -v

Deploy the operator from this branch.
Check the ServiceAccounts exist:

oc get sa -n openshift-adp openshift-adp-cli-server openshift-adp-vmdp-server

Check the deployments use them:

oc get deploy -n openshift-adp openshift-adp-oadp-cli-server openshift-adp-oadp-vmdp-server \
 -o jsonpath='{.spec.template.spec.serviceAccountName}{"\n"}'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 59cb7ff4-2887-4b95-b962-9c52013ed9c4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NicholasYancey
Once this PR has been reviewed and has the lgtm label, please assign dymurray for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shubham-pampattiwar]

@NicholasYancey Lets close this one and cherry-pick the oadp-dev PR #2318 once that gets merged.

[openshift-ci]

@NicholasYancey: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/5.0-e2e-test-hcp-aws	e048ef7	link	true	/test 5.0-e2e-test-hcp-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.