OADP-8484: Add startup probe to CLI download server

[NicholasYancey]

Why the changes were made

The CLI download server deployment on oadp-1.6/oadp-dev already added Readiness and Liveness probes (#2306), and oadp-1.3 got those plus a dedicated ServiceAccount via #2310. However, none of these included a StartupProbe.

Without one, the Liveness probe (initialDelaySeconds: 15) can start failing and restarting the container before it's actually finished starting up, especially under slow/loaded conditions — causing avoidable restart loops. A StartupProbe defers the Liveness probe until the container reports healthy, giving it more headroom to start.

This PR is part of the lifecycle probe requirement (readiness/liveness/startup) to self-recover from common failures per Kubernetes best practices.

How to test the changes made

go test ./controllers/... -run 'CLIServer' -v

1. Deploy the operator from this branch.
2. Check the StartupProbe is set:

   oc get deploy -n openshift-adp openshift-adp-oadp-cli-server \
     -o jsonpath='{.spec.template.spec.containers[0].startupProbe}{"\n"}'

3. Confirm the pod comes up healthy:

   oc get pods -n openshift-adp -l app=oadp-cli

[openshift-ci-robot]

@NicholasYancey: This pull request references OADP-8484 which is a valid jira issue.

Details

In response to this:

Why the changes were made

The CLI download server deployment on oadp-1.6/oadp-dev already added Readiness and Liveness probes (#2306), and oadp-1.3 got those plus a dedicated ServiceAccount via #2310. However, none of these included a StartupProbe.

Without one, the Liveness probe (initialDelaySeconds: 15) can start failing and restarting the container before it's actually finished starting up, especially under slow/loaded conditions — causing avoidable restart loops. A StartupProbe defers the Liveness probe until the container reports healthy, giving it more headroom to start.

This PR is part of the lifecycle probe requirement (readiness/liveness/startup) to self-recover from common failures per Kubernetes best practices.

How to test the changes made

go test ./controllers/... -run 'CLIServer' -v

1. Deploy the operator from this branch.
2. Check the StartupProbe is set:

oc get deploy -n openshift-adp openshift-adp-oadp-cli-server \
  -o jsonpath='{.spec.template.spec.containers[0].startupProbe}{"\n"}'

3. Confirm the pod comes up healthy:

oc get pods -n openshift-adp -l app=oadp-cli

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1f61a521-2372-4dfd-aa3c-24389b91f874

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[NicholasYancey]

/retest

[kaovilai]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Joeavaikath, kaovilai, NicholasYancey, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Joeavaikath,kaovilai,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@NicholasYancey: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.