Repository navigation
AROSLSRE-2394: declare RUN_COST_TAG_VALUE in the provision step and enable it for dev e2e-parallel jobs - #87928
galchammat wants to merge 1 commit into
Conversation
…nable it for dev e2e-parallel jobs
openshift-ci-robot
added
the
jira/valid-reference
|
@galchammat: This pull request references AROSLSRE-2394 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
needs-ok-to-test
|
Hi @galchammat. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Define the run cost tag value ci-operator/step-registry/aro-hcp/provision/environment/aro-hcp-provision-environment-ref.yaml |
Adds RUN_COST_TAG_VALUE with an empty default. The documentation describes BUILD_ID, literal values, and disabling run cost attribution. |
Set the build ID in ARO-HCP jobs ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main.yaml |
Sets RUN_COST_TAG_VALUE to BUILD_ID in the e2e-parallel, e2e-parallel-inplace-upgrade, e2e-parallel-ocp-nightly, and e2e-parallel-slow jobs. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Feature
Suggested reviewers: roivaz
Merge Risk: 
f72ca
-
The jobs continue to run, and no verified merge-blocking risk remains.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title accurately summarizes both changes: declaring RUN_COST_TAG_VALUE in the provision step and enabling it for the dev e2e-parallel jobs. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Stable And Deterministic Test Names PASS: The pull request changes only CI YAML configuration and a step-reference environment declaration. The diff adds RUN_COST_TAG_VALUE settings and documentation; it adds no Ginkgo test titles or le… Test Structure And Quality PASS: This pull request changes only two YAML configuration files. The diff adds an environment declaration and values for four jobs. It adds no Ginkgo test code or Itblocks, so the listed test-str…Microshift Test Compatibility PASS: The pull request changes only two YAML configuration files. It adds an environment declaration and enables that variable on four CI jobs. The diff adds no Ginkgo tests or test bodies, so the Mic… Single Node Openshift (Sno) Test Compatibility The pull request changes only CI YAML configuration and a step-reference environment declaration. It adds no Ginkgo e2e tests or test bodies, so the SNO compatibility check is not applicable. Topology-Aware Scheduling Compatibility The pull request changes only ci-operator job environment settings and a step-reference environment declaration. It does not add or modify deployment manifests, operator code, controllers, replicas, a… Ote Binary Stdout Contract PASS. The pull request changes only two YAML files. It adds CI environment configuration and documentation; it does not modify an OTE binary, Go code, suite setup, or any process-level stdout behavior… Ipv6 And Disconnected Network Test Compatibility The pull request changes only two YAML configuration files. It adds an environment declaration and enables that variable on four jobs. It adds no Ginkgo tests and introduces no IPv4 assumptions or ext… No-Weak-Crypto The pull request only adds the RUN_COST_TAG_VALUEenvironment declaration and sets it to"BUILD_ID"in four CI job configurations. The changed lines contain no MD5, SHA1, DES, 3DES, RC4, Blowfish,…Container-Privileges The pull request adds only RUN_COST_TAG_VALUE environment entries and documentation. The diff adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root execution … No-Sensitive-Data-In-Logs PASS: The pull request changes only CI YAML and a step-reference declaration. It adds RUN_COST_TAG_VALUE: "BUILD_ID"and documentation, with no logging statements, secret values, tokens, passwords, …Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
Full details: Stable And Deterministic Test Names
-
Explanation
PASS: The pull request changes only CI YAML configuration and a step-reference environment declaration. The diff adds RUN_COST_TAG_VALUE settings and documentation; it adds no Ginkgo test titles or legacy metadata prefixes. Therefore, no unstable or overly specific test name is introduced.
Full details: Test Structure And Quality
-
Explanation
PASS: This pull request changes only two YAML configuration files. The diff adds an environment declaration and values for four jobs. It adds no Ginkgo test code or
Itblocks, so the listed test-structure requirements do not apply.
Full details: Microshift Test Compatibility
-
Explanation
PASS: The pull request changes only two YAML configuration files. It adds an environment declaration and enables that variable on four CI jobs. The diff adds no Ginkgo tests or test bodies, so the MicroShift test compatibility check does not apply.
Full details: Topology-Aware Scheduling Compatibility
-
Explanation
The pull request changes only ci-operator job environment settings and a step-reference environment declaration. It does not add or modify deployment manifests, operator code, controllers, replicas, affinity, topology spread, node selectors, tolerations, or PDBs. Therefore, it introduces no topology-aware scheduling constraint covered by this check.
Full details: Ote Binary Stdout Contract
-
Explanation
PASS. The pull request changes only two YAML files. It adds CI environment configuration and documentation; it does not modify an OTE binary, Go code, suite setup, or any process-level stdout behavior. No explicit OTE stdout contract violation is introduced.
Full details: Ipv6 And Disconnected Network Test Compatibility
-
Explanation
The pull request changes only two YAML configuration files. It adds an environment declaration and enables that variable on four jobs. It adds no Ginkgo tests and introduces no IPv4 assumptions or external connectivity requirements under this check.
Full details: No-Weak-Crypto
-
Explanation
The pull request only adds the
RUN_COST_TAG_VALUEenvironment declaration and sets it to"BUILD_ID"in four CI job configurations. The changed lines contain no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom cryptography, or secret/token comparison logic.
Full details: Container-Privileges
-
Explanation
The pull request adds only RUN_COST_TAG_VALUE environment entries and documentation. The diff adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root execution setting in either changed file.
Full details: No-Sensitive-Data-In-Logs
-
Explanation
PASS: The pull request changes only CI YAML and a step-reference declaration. It adds
RUN_COST_TAG_VALUE: "BUILD_ID"and documentation, with no logging statements, secret values, tokens, passwords, PII, hostnames, or customer data. The provision command remains unchanged and only invokes the existing provisioning script.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
Comment @coderabbitai help to get the list of available commands.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: galchammat The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Summary
Minimal ci-operator wiring for DEV E2E run cost attribution (AROSLSRE-2394):
RUN_COST_TAG_VALUEin thearo-hcp-provision-environmentstep ref, default""— ci-operator only passes env vars the step ref declares, so without this declaration enabling it on any job is a silent no-op. The empty default keeps every other consumer of the step (including the capz-e2e job and the long-lived environments) unchanged. The literalBUILD_IDresolves to the job's Prow build ID, because ci-operator configuration cannot expand$(BUILD_ID)itself.e2e-paralleljobs (e2e-parallel,e2e-parallel-inplace-upgrade,e2e-parallel-ocp-nightly,e2e-parallel-slow, allARO_HCP_DEPLOY_ENV: ci01) withRUN_COST_TAG_VALUE: "BUILD_ID"— the per-run PR-validation jobs whose infrastructure spend should be attributable to a single job.With the variable set,
hack/ci/provision-environment.shpasses the tag to templatize's--resource-group-tags, which setsjobID.aro-hcp-ci.redhat.com=<BUILD_ID>on the resource groups the run creates (existing groups only have tag keys they already carry replaced), and the config override generator applies the same tag to the AKS cluster tags. Cost Management tag inheritance on the E2E subscriptions then attributes each job's spend.Depends on Azure/ARO-HCP#7436 (the tool-side implementation). Until that merges, the variable is read but nothing consumes the tag yet — the jobs behave as before.
Verification
mainexcept the intended additions.aro-hcp-provision-environmentstep (the optional capz-e2e job) and the periodic healthchecks (which use the separatearo-hcp-provision-from-mainstep) do not set the variable and stay untagged.Summary by CodeRabbit
The ARO HCP CI step ref now declares
RUN_COST_TAG_VALUEwith an empty default. Fourci01dev E2E jobs set it to"BUILD_ID":e2e-parallel,e2e-parallel-inplace-upgrade,e2e-parallel-ocp-nightly, ande2e-parallel-slow.This configures those jobs to identify their created resource groups with the Prow build ID for run cost attribution. Other consumers keep the empty default.