Repository navigation
ci: add manually-triggered promote workflow - #10
Merged
gboutry merged 3 commits intoSep 22, 2026
Merged
Conversation
hemanthnakkina
force-pushed
the
add-github-workflow-promote
branch
from
September 16, 2026 10:54
aac7e8a to
ecb9586
Compare
hmlanigan
reviewed
Sep 16, 2026
hmlanigan
left a comment
hmlanigan
left a comment
There was a problem hiding this comment.
Please update the description to include why this change is being made.
Collaborator
Author
|
On a VM, install act and nodejs secrets flle workflow input params Workflow trigger: Artifacts: Unzip artifcats: |
- workflow_dispatch with source, release and dry-run inputs - charmhub auth via CHARMHUB_AUTH secret (exported charmcraft credentials) passed to charmcraft as CHARMCRAFT_AUTH; falls back to local charmcraft login when unset - snap store auth via SNAPCRAFT_STORE_CREDENTIALS for snapcraft promote - revision list uploaded as workflow artifact
hemanthnakkina
force-pushed
the
add-github-workflow-promote
branch
from
September 17, 2026 03:16
ecb9586 to
52810e3
Compare
snapcraft promote command is interactive and asks user for y/N. Make it non-interactive by passing --yes argument to snapcraft promote command Signed-off-by: Hemanth Nakkina <hemanth.nakkina@canonical.com>
Collaborator
Author
Thanks for the review. Description updated |
The secrets are maintained as part of environment promotion and hence add the same in the github workflow. Signed-off-by: Hemanth Nakkina <hemanth.nakkina@canonical.com>
hmlanigan
approved these changes
Sep 21, 2026
Collaborator
|
Can we get an example of I'd like to see exactly what's promoted. I'm interested to see if we have resource revisions in this manifest |
Collaborator
Author
I dont have those results for this run But there is one in PR #9 description |
Collaborator
Author
And we do not have resource revisions. I do not think we require resource revisions in this file because any resource revision change, we should always update the charm revision during publish. |
Collaborator
|
Ok; thanks. then it's alright for this PR.
What about SRU and bug fixes that are package only? We need to test with a charm,but do we need to publish a new charm revision for that? We don't do the same for snaps updates |
gboutry
approved these changes
Sep 22, 2026
Collaborator
Author
For package fixes
|
Collaborator
no, not for SRU and CVE that needs fast publishing. Let's discuss that on the later sync |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently sunbeam-release is triggered on local machines. Instead add a workflow that can be triggered to promote sunbeam snaps/charms.
QA steps:
Links:
Jira card: OPEN-4773