-
Notifications
You must be signed in to change notification settings - Fork 114
Enable WSGI deployment strategy for neutron by default #2054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,7 +36,7 @@ spec: | |
| - name: RELATED_IMAGE_MARIADB_OPERATOR_MANAGER_IMAGE_URL | ||
| value: quay.io/openstack-k8s-operators/mariadb-operator@sha256:5501da826fd1e48b1e546033e7be64e008a34793ef9c995390b375250dafd937 | ||
| - name: RELATED_IMAGE_NEUTRON_OPERATOR_MANAGER_IMAGE_URL | ||
| value: quay.io/openstack-k8s-operators/neutron-operator@sha256:d45f5e323447ff76a9198b1ac0b5ee9c4b2b5fd47a989177a939a3edb0fcc650 | ||
| value: quay.io/ykarel/neutron-operator:v0.0.2 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔒 Security & Privacy | 🟠 Major | ⚡ Quick win Use one immutable, approved Neutron operator manager image. Both changed paths now use the mutable
🧰 Tools🪛 Checkov (3.3.10)[medium] 5-55: Containers should not run with allowPrivilegeEscalation (CKV_K8S_20) [medium] 5-55: Minimize the admission of root containers (CKV_K8S_23) 📍 Affects 2 files
🤖 Prompt for AI Agents |
||
| - name: RELATED_IMAGE_NOVA_OPERATOR_MANAGER_IMAGE_URL | ||
| value: quay.io/openstack-k8s-operators/nova-operator@sha256:13ae67ea4cc192eb64c77d220b9463862d48da92585a9f03d1d8c50c69f5acd8 | ||
| - name: RELATED_IMAGE_OCTAVIA_OPERATOR_MANAGER_IMAGE_URL | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -156,6 +156,9 @@ require ( | |
|
|
||
| replace github.com/openstack-k8s-operators/openstack-operator/api => ./api //allow-merging | ||
|
|
||
| // TEMPORARY dev pin for OSPRH-33113-default-master (neutron WSGI support) | ||
| replace github.com/openstack-k8s-operators/neutron-operator/api => github.com/karelyatin/neutron-operator/api v0.0.0-20260827134028-4c882fe52aa0 | ||
|
Comment on lines
+159
to
+160
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Remove the forbidden fork replacement before merging. The dependency replacement in 📍 Affects 2 files
🤖 Prompt for AI AgentsSource: Pipeline failures |
||
|
|
||
| // mschuppert: map to latest commit from release-4.20 tag | ||
| // must consistent within modules and service operators | ||
| replace github.com/openshift/api => github.com/openshift/api v0.0.0-20260710141509-36dec0bfafe4 //allow-merging | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: openstack-k8s-operators/openstack-operator
Length of output: 14686
🏁 Script executed:
Repository: openstack-k8s-operators/openstack-operator
Length of output: 36806
Use the metadata-agent image for the metadata-agent default. The default environment variable passes
openstack-neutron-server:master-latesttoedpm_neutron_metadata_agent_image, while the export script and dataplane samples useopenstack-neutron-metadata-agent-ovn. Align both paths.🧰 Tools
🪛 Checkov (3.3.10)
[medium] 3-198: Containers should not run with allowPrivilegeEscalation
(CKV_K8S_20)
[medium] 3-198: Minimize the admission of root containers
(CKV_K8S_23)
📍 Affects 2 files
config/operator/default_images.yaml#L81-L81(this comment)hack/export_related_images.sh#L81-L81🤖 Prompt for AI Agents