Repository navigation
Avoid OpMetricsDb construction when parsing device step events if only step markers and step times are required. - #3612
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_992579135
branch
from
October 2, 2026 23:34
47fb020 to
db65e43
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_992579135
branch
3 times, most recently
from
October 9, 2026 19:05
fde854b to
0272fcc
Compare
…y step markers and step times are required. ConvertDeviceTraceXPlaneToStepEventsWithOptions now supports DeviceStepEventsOptions to skip per-core op metrics and GPU stream event parsing when collect_op_metrics is false, leaving ConvertDeviceTraceXPlaneToStepEvents non-overloaded. ConvertXSpaceToEventTimeFractionAnalyzerResults uses ConvertDeviceTraceXPlaneToStepMarkers since it only needs step markers, avoiding unnecessary memory overhead and protobuf copying. PiperOrigin-RevId: 996682561
copybara-service
Bot
force-pushed
the
test_992579135
branch
from
October 9, 2026 19:21
0272fcc to
dee9a00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid OpMetricsDb construction when parsing device step events if only step markers and step times are required.
ConvertDeviceTraceXPlaneToStepEventsWithOptions now supports DeviceStepEventsOptions to skip per-core op metrics and GPU stream event parsing when collect_op_metrics is false, leaving ConvertDeviceTraceXPlaneToStepEvents non-overloaded. ConvertXSpaceToEventTimeFractionAnalyzerResults uses ConvertDeviceTraceXPlaneToStepMarkers since it only needs step markers, avoiding unnecessary memory overhead and protobuf copying.