Skip to content

[BNE-148] Create work package link block via hash command - #25231

Open
ihordubas99 wants to merge 1 commit into
devfrom
feature/bne-148-create-work-package-link-block-via-hash-command
Open

ihordubas99 wants to merge 1 commit into
devfrom
feature/bne-148-create-work-package-link-block-via-hash-command

Conversation

@ihordubas99

@ihordubas99 ihordubas99 commented Sep 10, 2026 •

Copy link
Copy Markdown
Collaborator

Ticket

https://community.openproject.org/wp/BNE-148

What are you trying to accomplish?

Wire up the #### hash command that creates a block-sized work package link. The feature itself lives in op-blocknote-extensions (opf/op-blocknote-extensions#246); this is the consumer side of it.

What approach did you choose and why?

The # menu now ships as <OpenProjectHashMenu />, alongside <OpenProjectFormattingToolbar />, so the editor no longer restates the trigger character and the menu's wiring - including what the new #### behaviour needs - stays on the extensions side. Nothing to change here when it grows further.

Needs the op-blocknote-extensions release that exports OpenProjectHashMenu. The dependency bump in frontend/package.json is not in this PR yet - it has to land here before this can be merged, otherwise the frontend build fails on the missing export.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@ihordubas99 ihordubas99 self-assigned this Sep 10, 2026
@ihordubas99
ihordubas99 force-pushed the feature/bne-148-create-work-package-link-block-via-hash-command branch from a9e605f to 39e9c5b Compare September 10, 2026 10:18
@ihordubas99
ihordubas99 marked this pull request as ready for review September 10, 2026 10:18
@github-actions

Copy link
Copy Markdown

Caution

The Enterprise plan field is not set on the work package

Details:

Please make sure that:

  • The work package Enterprise plan field is set

@judithroth judithroth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement with the OpenProjectHashMenu!
We have to wait with merging this until the next release of BNE of course.

I get one failure with the changes of this and opf/op-blocknote-extensions#246 though:

Failures:

  1) BlockNote editor rendering with op-blocknote-extensions orders results of the work package search by updated at DESC
     Failure/Error: expect(editor.element).to have_content("AAA test") # wait for dropdown to open
       expected to find text "AAA test" in ""
     # ./modules/documents/spec/features/block_note_editor_spec.rb:151:in 'block (3 levels) in <top (required)>'
     # ./spec/support/capybara.rb:22:in 'block (2 levels) in <top (required)>'
     # ./spec/support/shared/without_env.rb:52:in 'block (2 levels) in <top (required)>'
     # ./spec/support/shared/with_env.rb:60:in 'block (2 levels) in <top (required)>'
     # ./spec/support/shared/with_direct_uploads.rb:219:in 'block (2 levels) in <top (required)>'
     # ./spec/support/cuprite_setup.rb:164:in 'block (2 levels) in <top (required)>'
     # -e:1:in 'Kernel#require'
     # -e:1:in '<main>'

rspec ./modules/documents/spec/features/block_note_editor_spec.rb:141

getItems={getHashItems}
suggestionMenuComponent={HashWpMenu}
/>
<OpenProjectHashMenu />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ihordubas99
ihordubas99 force-pushed the feature/bne-148-create-work-package-link-block-via-hash-command branch from 39e9c5b to efaf1a4 Compare September 30, 2026 14:51
@ihordubas99

Copy link
Copy Markdown
Collaborator Author

Hi @judithroth, thanks for checking!

I rebased onto dev and the spec passes locally now, together with the new #### tests 👌

@judithroth judithroth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(please do not merge yet, BNE needs to be released first)

@ihordubas99
ihordubas99 force-pushed the feature/bne-148-create-work-package-link-block-via-hash-command branch from efaf1a4 to 2ce3b3e Compare October 26, 2026 11:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants