Repository navigation
[BNE-148] Create work package link block via hash command - #25231
Open
ihordubas99 wants to merge 1 commit into
Open
ihordubas99 wants to merge 1 commit into
ihordubas99 wants to merge 1 commit into
Conversation
2 of 3 tasks
ihordubas99
force-pushed
the
feature/bne-148-create-work-package-link-block-via-hash-command
branch
from
September 10, 2026 10:18
a9e605f to
39e9c5b
Compare
ihordubas99
marked this pull request as ready for review
September 10, 2026 10:18
|
Caution The Enterprise plan field is not set on the work package Details:
Please make sure that:
|
judithroth
requested changes
Sep 30, 2026
judithroth
left a comment
Contributor
There was a problem hiding this comment.
Nice improvement with the OpenProjectHashMenu!
We have to wait with merging this until the next release of BNE of course.
I get one failure with the changes of this and opf/op-blocknote-extensions#246 though:
Failures:
1) BlockNote editor rendering with op-blocknote-extensions orders results of the work package search by updated at DESC
Failure/Error: expect(editor.element).to have_content("AAA test") # wait for dropdown to open
expected to find text "AAA test" in ""
# ./modules/documents/spec/features/block_note_editor_spec.rb:151:in 'block (3 levels) in <top (required)>'
# ./spec/support/capybara.rb:22:in 'block (2 levels) in <top (required)>'
# ./spec/support/shared/without_env.rb:52:in 'block (2 levels) in <top (required)>'
# ./spec/support/shared/with_env.rb:60:in 'block (2 levels) in <top (required)>'
# ./spec/support/shared/with_direct_uploads.rb:219:in 'block (2 levels) in <top (required)>'
# ./spec/support/cuprite_setup.rb:164:in 'block (2 levels) in <top (required)>'
# -e:1:in 'Kernel#require'
# -e:1:in '<main>'
rspec ./modules/documents/spec/features/block_note_editor_spec.rb:141
| getItems={getHashItems} | ||
| suggestionMenuComponent={HashWpMenu} | ||
| /> | ||
| <OpenProjectHashMenu /> |
ihordubas99
force-pushed
the
feature/bne-148-create-work-package-link-block-via-hash-command
branch
from
September 30, 2026 14:51
39e9c5b to
efaf1a4
Compare
Collaborator
Author
|
Hi @judithroth, thanks for checking! I rebased onto dev and the spec passes locally now, together with the new #### tests 👌 |
judithroth
approved these changes
Oct 21, 2026
judithroth
left a comment
Contributor
There was a problem hiding this comment.
(please do not merge yet, BNE needs to be released first)
ihordubas99
force-pushed
the
feature/bne-148-create-work-package-link-block-via-hash-command
branch
from
October 26, 2026 11:50
efaf1a4 to
2ce3b3e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/BNE-148
What are you trying to accomplish?
Wire up the
####hash command that creates a block-sized work package link. The feature itself lives in op-blocknote-extensions (opf/op-blocknote-extensions#246); this is the consumer side of it.What approach did you choose and why?
The
#menu now ships as<OpenProjectHashMenu />, alongside<OpenProjectFormattingToolbar />, so the editor no longer restates the trigger character and the menu's wiring - including what the new####behaviour needs - stays on the extensions side. Nothing to change here when it grows further.Needs the op-blocknote-extensions release that exports
OpenProjectHashMenu. The dependency bump infrontend/package.jsonis not in this PR yet - it has to land here before this can be merged, otherwise the frontend build fails on the missing export.Merge checklist