Skip to content

[DREAM-77] Primerise PDF export tabs of Admin/Design page - #26234

Merged
HDinger merged 3 commits into
devfrom
feature/dream-77-primerise-pdf-export-tabs-of-admin-design-page
Oct 26, 2026
Merged

HDinger merged 3 commits into
devfrom
feature/dream-77-primerise-pdf-export-tabs-of-admin-design-page

Conversation

@HDinger

@HDinger HDinger commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Ticket

https://community.openproject.org/wp/DREAM-77
https://community.openproject.org/wp/DREAM-917

What are you trying to accomplish?

In the admin/design page:

  • Merge the two pdf export tabs
  • Use the color field consistently
  • Use the file field consistently pdf export tab
  • Extract the colors list component to re-use it in the pdf export tab

Screenshots

Bildschirmfoto 2026-10-22 um 16 00 18

AI involvement

Collaborative – AI generated a substantial part of the code; I reviewed and understand every line.

@github-actions github-actions Bot added the ai: Collaborative 💻 AI generated a substantial part of the code; A human reviewed and understands every line. label Oct 22, 2026
@opf opf deleted a comment from github-actions Bot Oct 22, 2026
@opf opf deleted a comment from github-actions Bot Oct 22, 2026
@HDinger
HDinger added this pull request to stack #26235 October 22, 2026 14:03
@HDinger HDinger added this to the 18.0.x milestone Oct 22, 2026
@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./modules/bim/spec/features/viewer/create_viewpoint_spec.rb[1:1:1:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #26234, linked for reference only):

- `rspec ./modules/bim/spec/features/viewer/create_viewpoint_spec.rb[1:1:1:1]`

Treat this as a standalone task, unrelated to PR #26234. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #26234 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @HDinger to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @HDinger, and request a review from @HDinger.
On every commit, set @HDinger as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

Comment thread app/views/custom_styles/_pdf_export_styles.html.erb Outdated
@HDinger
HDinger force-pushed the feature/dream-77-primerise-pdf-export-tabs-of-admin-design-page branch from effd516 to 320fb4b Compare October 26, 2026 07:58
@HDinger
HDinger requested a review from bsatarnejad October 26, 2026 08:00

@bsatarnejad bsatarnejad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Looks great to me!

Base automatically changed from feature/dream-75-primerise-branding-tab-of-admin-design-page to dev October 26, 2026 11:40
@HDinger
HDinger force-pushed the feature/dream-77-primerise-pdf-export-tabs-of-admin-design-page branch from 320fb4b to f90ef1b Compare October 26, 2026 11:40
@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./spec/features/work_packages/table/queries/id_filter_spec.rb[1:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #26234, linked for reference only):

- `rspec ./spec/features/work_packages/table/queries/id_filter_spec.rb[1:1]`

Treat this as a standalone task, unrelated to PR #26234. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #26234 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @HDinger to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @HDinger, and request a review from @HDinger.
On every commit, set @HDinger as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@HDinger
HDinger merged commit 803f1e1 into dev Oct 26, 2026
17 checks passed
@HDinger
HDinger deleted the feature/dream-77-primerise-pdf-export-tabs-of-admin-design-page branch October 26, 2026 12:00
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ai: Collaborative 💻 AI generated a substantial part of the code; A human reviewed and understands every line. feature needs review

Development

Successfully merging this pull request may close these issues.

2 participants