Repository navigation
Conversation
…import run instead of reusing the one it created before https://community.openproject.org/wp/JIM-263
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
klappradla
reviewed
Oct 26, 2026
klappradla
left a comment
Contributor
There was a problem hiding this comment.
Neat ✨
I left some comments / questions here and there. One thing I think could be worth considering (also in the tests) is, that a field from Jira could already have a (<number>) suffix.
Plus - even though it's not necessarily related to the bug this is fixing - it would also make sense to align the candidate matching for the system fields that are mapped to custom fields (right now only resolution date) with the new logic and have it centralized in one module.
Co-authored-by: Max Mulatz <max@bitcrowd.net>
…s-a-new-numbered-custom-field-on-every-import-run-instead-of-reusing-the-one-it-created-before' into bug/jim-263-jira-migrator-creates-a-new-numbered-custom-field-on-every-import-run-instead-of-reusing-the-one-it-created-before
klappradla
approved these changes
Oct 26, 2026
as-op
deleted the
bug/jim-263-jira-migrator-creates-a-new-numbered-custom-field-on-every-import-run-instead-of-reusing-the-one-it-created-before
branch
October 26, 2026 12:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/JIM-263
What are you trying to accomplish?
if the OP instance already has a custom field (e.g. "Story Points") with a different format (e.g. an integer one), but the imported Jira "Story Points" are of type float, the format filter drops it => migrator creates "Story Points (2)".
On the next import run, Story Points (2) is a compatible candidate but is not matched => Story Points (3) and so on,
What approach did you choose and why?
The solution is to look at the base name of existing custom fields without the number suffix, so "Story Points (2)" can be found by a Jira custom field "Story Points". Text based suffixes like "Story Points (archived)" are not considered.
Merge checklist