Skip to content

Allow refreshing metadata manually - #26262

Merged
oliverguenther merged 3 commits into
devfrom
fix/saml-metadata
Oct 26, 2026
Merged

oliverguenther merged 3 commits into
devfrom
fix/saml-metadata

Conversation

@oliverguenther

@oliverguenther oliverguenther commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Ticket

https://community.openproject.org/projects/OP/work_packages/OP-20460/activity

What are you trying to accomplish?

  • Allow manually refreshing the SAML metadata
  • Allow administrators to review the SAML metadata before applying it
  • To avoid fetching the metadata twice, pass the options to the form, but use a verifying token to ensure the options have not been tampered with.

Screenshots

2026-10-26_13-12-16@2x 2026-10-23_08-20-40@2x

What approach did you choose and why?

AI involvement

Collaborative – AI generated a substantial part of the code; I reviewed and understand every line.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@github-actions github-actions Bot added the ai: Collaborative 💻 AI generated a substantial part of the code; A human reviewed and understands every line. label Oct 23, 2026
@NobodysNightmare

Copy link
Copy Markdown
Contributor

Has the placement of the "refresh metadata" button been aligned with UX?

I think we never added an interactive element in this position of the wizards yet and it feels wrong to me.

I'd probably put it in either of those places:

  • inside the "metadata" menu entry
  • in the side panel

The side panel has precedence to house "service buttons" in storages already, e.g. the "sync now" button for AMPF:

image

@psatyal

psatyal commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Hi @oliverguenther, @NobodysNightmare:

Yes, I think it makes more sense to put it in the sidebar. There could be a Metadata section, right?

Title: Metadata
Text: You can check if the configuration fetched from your identity provider has changed.
Action: Refresh metadata

Thoughts?

Cheers
Parimal

@NobodysNightmare NobodysNightmare left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few comments. I think none of them are blocking per se.

Comment thread modules/auth_saml/app/controllers/saml/providers_controller.rb Outdated
Comment thread modules/auth_saml/app/controllers/saml/providers_controller.rb Outdated
Comment thread modules/auth_saml/app/views/saml/providers/refresh_metadata.html.erb Outdated
@oliverguenther
oliverguenther force-pushed the fix/saml-metadata branch 2 times, most recently from 4dc77c3 to 1a2beb1 Compare October 26, 2026 12:35
@oliverguenther
oliverguenther merged commit c7cca89 into dev Oct 26, 2026
17 checks passed
@oliverguenther
oliverguenther deleted the fix/saml-metadata branch October 26, 2026 13:16
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ai: Collaborative 💻 AI generated a substantial part of the code; A human reviewed and understands every line. bugfix needs review

Development

Successfully merging this pull request may close these issues.

3 participants