Skip to content

Merge release/17.9 into dev - #26295

Merged
myabc merged 8 commits into
devfrom
merge-release/17.9-20261025034710
Oct 25, 2026
Merged

myabc merged 8 commits into
devfrom
merge-release/17.9-20261025034710

Conversation

@openprojectci

Copy link
Copy Markdown
Contributor

Created by GitHub action
Replaces #26289

@openprojectci openprojectci added the create-merge-release-into-dev-pr Mark auto created PRs that will be auto closed too label Oct 25, 2026
myabc added 2 commits October 25, 2026 20:12
# Conflicts:
#	AGENTS.md
#	frontend/AGENTS.md
#	package-lock.json
#	package.json
Aligns the op-blocknote-extensions test and publish workflows with
the Node version pinned everywhere else on the release branch and
required by the root package.json engines field.
@myabc myabc self-assigned this Oct 25, 2026
@myabc
myabc requested a review from ihordubas99 October 25, 2026 20:14
@myabc

myabc commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

@ihordubas99 @brunopagno @judithroth FYI d1dbc00 .. ideally we should use the same node eveywhere / @oliverguenther

@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./spec/features/work_packages/table/queries/id_filter_spec.rb[1:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #26295, linked for reference only):

- `rspec ./spec/features/work_packages/table/queries/id_filter_spec.rb[1:1]`

Treat this as a standalone task, unrelated to PR #26295. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #26295 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @openprojectci to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @openprojectci, and request a review from @openprojectci.
On every commit, set @openprojectci as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@myabc
myabc merged commit d3f694c into dev Oct 25, 2026
27 of 28 checks passed
@myabc
myabc deleted the merge-release/17.9-20261025034710 branch October 25, 2026 20:31
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

create-merge-release-into-dev-pr Mark auto created PRs that will be auto closed too

Development

Successfully merging this pull request may close these issues.

3 participants