Skip to content

[BNE-178] Don't run OP workflows if changes affect only extensions - #26314

Merged
judithroth merged 2 commits into
devfrom
code-maintenance/bne-178-don-t-run-op-workflows-if-changes-affect-only-extensions-blocknote-extensions
Oct 26, 2026
Merged

judithroth merged 2 commits into
devfrom
code-maintenance/bne-178-don-t-run-op-workflows-if-changes-affect-only-extensions-blocknote-extensions

Conversation

@judithroth

Copy link
Copy Markdown
Contributor

https://community.openproject.org/wp/BNE-178

Ticket

https://community.openproject.org/wp/BNE-178

What are you trying to accomplish?

Keep CI usage low by not triggering unnecessary workflows

AI involvement

Collaborative – AI generated a substantial part of the code; I reviewed and understand every line.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

Copilot AI balanced review requested due to automatic review settings October 26, 2026 08:47
@github-actions github-actions Bot added the ai: Collaborative 💻 AI generated a substantial part of the code; A human reviewed and understands every line. label Oct 26, 2026
@github-actions

Copy link
Copy Markdown

Caution

The provided work package version does not match the core version

Details:

Please make sure that:

  • The work package version OR your pull request target branch is correct

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrowly scoped path filters preserve eligible core triggers, and no blocking issues were identified.

No open issues 🎉

What changed in this PR

Reduces OpenProject CI usage by skipping six core workflows when changes affect only extensions/blocknote-extensions.

Changes:

  • Adds the extension directory to existing push and pull-request ignore filters.
  • Excludes extension files from core ESLint triggers while preserving triggers for eligible core changes.
File Description
.github/​workflows/​test-core.yml Skips core tests for extension-only changes.
.github/​workflows/​rubocop-core.yml Skips core Ruby linting for extension-only changes.
.github/​workflows/​i18n-tasks.yml Skips translation checks for extension-only changes.
.github/​workflows/​eslint-core.yml Excludes extension files from core ESLint triggers.
.github/​workflows/​downstream-ci.yml Skips downstream CI for extension-only changes.
.github/​workflows/​danger.yml Skips Danger checks for extension-only changes.

Review effort: Balanced

@judithroth
judithroth requested review from a team, brunopagno and myabc and removed request for a team October 26, 2026 08:49
- "help/**"
- "packaging/**"
- ".pkgr.yml"
- "extensions/blocknote-extensions/**"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@judithroth shouldn't this apply to all extensions/ directories?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Let's leave it per folder in extensions - we don't know what kind of extension we're adding next 🙂

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think extensions is a safe bet, since Ruby code is likely to remain in the monolith. That said, this isn't a blocker for me.

@judithroth
judithroth force-pushed the code-maintenance/bne-178-don-t-run-op-workflows-if-changes-affect-only-extensions-blocknote-extensions branch from 69f28dc to 571e289 Compare October 26, 2026 09:29
@judithroth
judithroth requested a review from myabc October 26, 2026 09:29
@judithroth judithroth changed the title [BNE-178] Don't run OP workflows if changes affect only extensions/blocknote-extensions [BNE-178] Don't run OP workflows if changes affect only extensions Oct 26, 2026

@myabc myabc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might make sense to switch to explicitly including paths rather than excludes for all tasks, but that is a bigger overhaul of CI workflows and would need input from @oliverguenther and team.

This is a nice improvem3ent in the meantime.

@judithroth
judithroth merged commit 888057c into dev Oct 26, 2026
16 of 17 checks passed
@judithroth
judithroth deleted the code-maintenance/bne-178-don-t-run-op-workflows-if-changes-affect-only-extensions-blocknote-extensions branch October 26, 2026 12:51
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ai: Collaborative 💻 AI generated a substantial part of the code; A human reviewed and understands every line.

Development

Successfully merging this pull request may close these issues.

3 participants