[tisba]

Follow-up for #26209

Ticket

https://community.openproject.org/wp/OP-20529

What are you trying to accomplish?

I actually missed a piece of feedback in #26209 (comment) about avoiding a redundant check, if the user can view members. While mentioning this to @ulferts we realized that we also can avoid loading Member instances altogether since we want to have Principal instances ultimately.

What approach did you choose and why?

Load Principal directly and by that skipping also the extra membership visibility check. #members_by_role already does an explicit check in the very beginning (introduced in #26209).

The resulting query, executed once per role looks like this now:

SELECT "users"."id", "users"."login", "users"."firstname", "users"."lastname", "users"."mail", "users"."admin", "users"."status", "users"."last_login_on", "users"."language", "users"."ldap_auth_source_id", "users"."created_at", "users"."updated_at", "users"."type", "users"."first_login", "users"."force_password_change", "users"."failed_login_count", "users"."last_failed_login_on", "users"."consented_at", "users"."webauthn_id"
FROM "users"
INNER JOIN "members" ON "users"."id" = "members"."user_id"
INNER JOIN "members" "members_users" ON "members_users"."user_id" = "users"."id"
INNER JOIN "member_roles" ON "member_roles"."member_id" = "members_users"."id"
LEFT OUTER JOIN "users" "principals_members" ON "principals_members"."status" != $1 AND "principals_members"."id" = "members"."user_id"
WHERE "members"."project_id" = $2 AND "users"."status" != $3 AND "users"."type" NOT IN ($4, $5, $6, $7) AND "users"."status" != $8 AND "member_roles"."role_id" = $9
ORDER BY "members"."created_at" DESC
LIMIT $10

AI involvement

None

Merge checklist

• Added/updated tests
• Added/updated documentation in Lookbook (patterns, previews, etc)
• Tested major browsers (Chrome, Firefox, Edge, ...)