Skip to content

Refined design batch 3: pillar, tutorial, hearts, blog, cert, media/agenda and store pages - #410

Merged
gregv merged 1 commit into
developfrom
feat/refined-design-batch-3
Oct 23, 2026
Merged

gregv merged 1 commit into
developfrom
feat/refined-design-batch-3

Conversation

@gregv

@gregv gregv commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Summary

Batch 3 of the civic-editorial rollout. Every page on the CLAUDE.md "still not refined" list except /signup2, /unsubscribe and /census now renders inside RefinedRoot (Fraunces display + Hanken body, warm paper, navy/terracotta, hairline cards, native <details> FAQs, navy CTA bands). Head / getStaticProps / JSON-LD / GA calls / hrefs were preserved; getStaticProps output is byte-identical on the three core pillar pages.

Pages (22 routes):

  • SEO pillars: /coding-for-nonprofits, /hackathon-for-social-good, /hackathon-judging-criteria, /hackathon-judge-opportunities, /volunteer/professional-development-volunteering, /about/hackers/software-engineering-career-path, /about/locations/asu-tempe-arizona
  • Video tutorials: /about/judges/overview, /about/mentors/overview, /judge/overview — one shared VideoGuidePage template driven by per-route config
  • /about/hearts + /community-champions — both server-rendered now; tiers/categories come only from src/lib/heartTiers.js
  • /blog/[blog_id] (SingleBlogPost + SingleNews), /cert, /cert/[cert_id] (ISR/OG contract untouched)
  • /hack/[event_id]/media + /agenda — Shell + TeamBreadcrumbs, fetchForStaticProps semantics
  • Store: /store, /store/cart, /store/success, /store/products/[id]

Bugs fixed on the way

  • trackEvent was called positionally (trackEvent("name", label)) on the tutorial pages, /about/judges and /about/hearts, so GA received an undefined event name.
  • Variation items (shirts, hoodies) could not be removed from the cart — the cartKey lookup matched nothing.
  • CertInfoIndex fetched /api/certificates/undefined during ISR fallback and had no not-found state.
  • /media prerendered every event at build time (the Oct 7 deploy-killer pattern); now paths: [] + fallback: "blocking". Media and agenda both rethrow upstream failures so ISR keeps the last good copy.
  • Agenda formatted times in the host timezone (wrong on Vercel + hydration mismatch); now Intl in the event timezone with a mount-gated clock.
  • Canonicals on the professional-development and career-path pages pointed at opportunityhack.org; hearts og:url pointed at mentor.ohack.dev (and was spelled org:url); the PDV CTA linked to a 404 (/hackathon).
  • Blog eyebrow printed raw legacy timestamps; now "June 11, 2026".

Known / not fixed here

  • Store catalog images /images/store/*.png never existed in the repo and 404 in production. Cards and cart thumbs now fall back to a Fraunces initial via onError; the PNGs still need to be added (or store-products.json repointed).
  • /store/products/[id] has no getStaticProps (pre-existing), so its Product JSON-LD/OG are client-only.
  • The judge tutorial VideoObject durations (10m30s / 15m) disagree with the 5/8-minute body copy and use playerType: "HTML5 Flash" — left verbatim.
  • Dead Certificate.js / Certificate/styles.js deleted.

Verification

  • npx jest --ci: 84 suites, 604 tests passing.
  • npx next build: passes (all 22 routes build; media/agenda as ISR).
  • Playwright sweep of all 22 routes at 1280px and 390px against the local backend: every route 200, exactly one <h1>, RefinedRoot paper background, no horizontal overflow on phone width. The only console error is the pre-existing dev-only NavBarPlaceholder hydration warning (also fires on the already-merged /sponsor).
  • Store flow exercised in the browser: pick variation → Add to cart (inline status) → cart row + total → + doubles the total → Remove empties the cart.

Test plan

Click through on the Vercel preview (desktop + phone width):

  • /coding-for-nonprofits, /hackathon-for-social-good, /hackathon-judging-criteria: hero + stat row, FAQ <details> open/close, every CTA lands (nonprofit apply, /hack, /sponsor, /hackathon-judging-criteria#scorecard); view-source has one FAQPage block with 8 questions.
  • /hackathon-judge-opportunities: upcoming-events band shows the Fall 2026 event with an Apply button; the criteria <details> sliders and the "Training score / 40" card still work; Corporate Judge Programs → /sponsor.
  • /volunteer/professional-development-volunteering + /about/hackers/software-engineering-career-path: title/canonical say www.ohack.dev; "Volunteer at the next event" → /hack.
  • /about/locations/asu-tempe-arizona: venue picker toggles G-Wing ↔ Hayden (URL ?location=), section Share buttons copy a #venue/#parking… link and show the toast, hotel tel: links.
  • /about/judges/overview, /about/mentors/overview, /judge/overview: video plays in the 16:9 frame, Share copies the link with the inline "Link copied", /judge/overview shows the Round 1 / Round 2 quick-reference cards, resource tiles open (external in new tab). GA DebugView: click_judges_overview / click_mentors_overview events now carry a name.
  • /about/hearts: tier ladder matches your profile's Hearts tab (Bronze → Diamond), scoring guide <details>, "Check your hearts" → /profile#hearts.
  • /community-champions: table loads with ranks + avatars, search filters, tier chips filter with counts, List/Grid toggle, name → /profile/<id> opens the right person. Try with the backend unreachable: calm error card + Retry.
  • /blog/<any post>: date eyebrow formatted, featured image, markdown body, one tag strip, "Copy excerpt" inline status, related posts, "All posts" back link; a legacy Slack-only post still renders.
  • /cert: search + repo filter; /cert/<real id>: certificate image, stats, Download; /cert/garbage → 404 page.
  • /hack/cal_poly_humboldt_2025/media: carousel arrows/dots/thumb strip, caption "Open full photo", coverage tile; /hack/2024_fall/agenda: day groups in MST, "Print agenda" shows the QR strip in print preview; an event with no countdowns shows the empty state; an unknown event id → 404.
  • Store: /store search + category tags; /store/products/ohack-tshirt-classic pick size → Add to cart → inline "Added to cart"; /store/cart − / + clamp at 1 and 50, Remove works on a variation item, Checkout reaches Stripe; /store/success?session_id=… shows the order card. Note images are placeholders until the PNGs exist.

🤖 Generated with Claude Code

…s, blog, cert, media/agenda and store pages

Batch 3 of the refined rollout — every page left on the "still not refined"
list except /signup2, /unsubscribe and /census now renders inside RefinedRoot
(Fraunces display + Hanken body, warm paper, navy/terracotta, hairline cards,
native <details> FAQs, navy CTA bands). Head/getStaticProps/JSON-LD/GA and
every href were kept; getStaticProps output is byte-identical on the three
core pillar pages.

Pages: /coding-for-nonprofits, /hackathon-for-social-good,
/hackathon-judging-criteria, /hackathon-judge-opportunities,
/volunteer/professional-development-volunteering,
/about/hackers/software-engineering-career-path,
/about/locations/asu-tempe-arizona, /about/judges/overview,
/about/mentors/overview, /judge/overview (one shared VideoGuidePage template),
/about/hearts, /community-champions (both SSR now, tiers from heartTiers.js),
/blog/[blog_id] (SingleBlogPost + SingleNews), /cert, /cert/[cert_id],
/hack/[event_id]/media, /hack/[event_id]/agenda, /store, /store/cart,
/store/success, /store/products/[id].

Bugs fixed along the way:
- trackEvent was called positionally on the tutorial pages, /about/judges and
  /about/hearts, sending an undefined GA event name.
- Variation items could not be removed from the cart (cartKey lookup matched
  nothing).
- CertInfoIndex fetched /api/certificates/undefined during ISR fallback.
- Media prerendered every event at build time; now paths: [] + blocking.
  Both media and agenda rethrow upstream failures (ISR keeps last good copy).
- Agenda formatted times in the host timezone (wrong on Vercel + hydration
  mismatch); now Intl in the event tz with a mount-gated clock.
- Canonicals on the PDV and career-path pages pointed at opportunityhack.org;
  hearts og:url pointed at mentor.ohack.dev; PDV's /hackathon CTA was a 404.
- Blog eyebrow printed raw legacy timestamps.

Deleted dead Certificate.js/styles.js. CLAUDE.md + design-system doc updated.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
frontend-ohack-dev Ready Ready Preview Oct 23, 2026 6:08am UTC

Request Review

@gregv
gregv merged commit 1182f5b into develop Oct 23, 2026
5 checks passed
@gregv
gregv deleted the feat/refined-design-batch-3 branch October 23, 2026 16:05

This branch was successfully deployed

1 active deployment
Preview — 6374a052 Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant